-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System ready] Extend sysmonitor functionality to wait for host daemons #18817
Open
fastiuk
wants to merge
14
commits into
sonic-net:master
Choose a base branch
from
fastiuk:dev-sysready-extension
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6e975c3
System-ready: Update YANG model
fastiuk 376a4d1
System-ready: Add YANG model tests
fastiuk e50e33c
System-ready: Update configuration reference
fastiuk bcd3883
System-ready: Extend sysmonitor to listen for daemons
fastiuk 592dcb7
System-ready: Report syncd ready status
fastiuk 981243a
System-ready: Update features' configuration
fastiuk 85ca8a9
System-ready: SNMP should wait for system ready event
fastiuk 39d1e8d
System-ready: Add sysmonitor tests
fastiuk de110cf
🐞 sysmonitor: Skip error logging of inactive srvs
fastiuk c210287
Merge branch 'master' into dev-sysready-extension
fastiuk 544dfa2
System ready: Update overlap wait time to 1 minute
fastiuk 7f21c07
Merge branch 'master' into dev-sysready-extension
fastiuk 8dc3b19
Merge branch 'master' into dev-sysready-extension
fastiuk a9b865e
Merge branch 'master' into dev-sysready-extension
fastiuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
System-ready: SNMP should wait for system ready event
Signed-off-by: Yevhen Fastiuk <[email protected]>
commit 85ca8a9022c2f10058ca56d633a0ba750824c491
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgsudharsan It is disabled for snmp by default: see
files/build_templates/init_cfg.json.j2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is different. In the init_cfg.j2 you are considering snmp as irrelevent for system ready but using system ready as a criteria to spawn snmp. Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you consider handling this logic through featured? Today we have a similar flow in featured where certain daemons are spawned after portinitdone. In this case the critera can be systemd. It can be much easy to extend this to multiple daemons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is indeed correct. Irrelevant for system ready means that
system ready
feature won't just collect readiness status of snmp systemd service. But SNMP must be started after system is ready. The logic actually does't break each other.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the code in
featured
and I don't want to break anything there by adding wait for system ready. Most of thedelayed
services there depend on portinit done, and I don't want to add another wait point there as it will just make the logic there more complex and less clear.