Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia][sonic-platform] Update nokia sonic-platform submodule with thermal coherence changes to be paired with NDK >= 22.9.26 #18565

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

snider-nokia
Copy link
Contributor

@snider-nokia snider-nokia commented Apr 4, 2024

These changes ensure proper thermal subsystem operation when removing ASIC internal thermal sensor polling from NDK.
- Please pair this submodule update with NDK >= 22.9.26 : NDK 22.9.26 PR is here: Azure/sonic-buildimage-msft#316
- This PR is 202205 specific. The associated master PR is here: #18564

Edit: Now also includes kernel module changes for error level messages to warning level (this change is 202205 specific and not applicable to master) as well as fix for show chassis module with correct linecard description (https://github.com/Nokia-ION/ndk/issues/45).

Why I did it

These changes are required in order to ensure thermal subsystem coherence when removing 'bcmcmd show pvt' ASIC thermal sensor polling from NDK.

Please pair this submodule update with NDK >= 22.9.26 : NDK 22.9.26 PR is here: Azure/sonic-buildimage-msft#316

Work item tracking
  • Microsoft ADO (number only):

How I did it

Made the necessary modifications to facilitate coherent temp sensor operations.

How to verify it

Verify that thermal subsystem operates normally via 'show platform temperature' command.

Please pair this submodule update with NDK >= 22.9.26 : NDK 22.9.26 PR is here: Azure/sonic-buildimage-msft#316

Which release branch to backport (provide reason below if selected)

@snider-nokia snider-nokia requested a review from lguohan as a code owner April 4, 2024 16:15
@snider-nokia
Copy link
Contributor Author

@judyjoseph, Can you please review and merge? Thanks.

@judyjoseph
Copy link
Contributor

judyjoseph commented Apr 18, 2024

@snider-nokia could you update the platform modules update Pr with the fix for https://github.com/Nokia-ION/ndk/issues/45 also, before we merge @rlhui f.y.i

…ng SONiC SAI native ASIC thermal sensor polling

Also now including kernel module changes that make error level message warning level
Also now including show chassis module with correct linecard description
@snider-nokia
Copy link
Contributor Author

@snider-nokia could you update the platform modules update Pr with the fix for Nokia-ION/ndk#45 also, before we merge @rlhui f.y.i

Ok, all set now @judyjoseph.

@gechiang
Copy link
Collaborator

@snider-nokia , can you also ensure fixes like this are always pushed to public master as well? and its corresponding SDK also in msft repo Master?
Thanks!

@snider-nokia
Copy link
Contributor Author

snider-nokia commented Apr 18, 2024

@snider-nokia , can you also ensure fixes like this are always pushed to public master as well? and its corresponding SDK also in msft repo Master? Thanks!

Yes @gechiang, we are doing so. Some Nokia PMON changes are either master or 202205 specific, so we are handling individually (but keeping a close eye to ensure all changes are made at both branches). Also, we will discuss NDK at next appropriate meeting since the master and 202205 builds have now diverged there as well. Will keep you informed as to any/all decisions made in this regard.

@rlhui rlhui merged commit b1e28b0 into sonic-net:202205 Apr 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants