Add base gnmi docker image #17292
Open
Add base gnmi docker image #17292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuh-80
approved these changes
Nov 24, 2023
lguohan
reviewed
Nov 29, 2023
| @@ -31,6 +31,9 @@ $(DOCKER_TELEMETRY)_CONTAINER_NAME = telemetry | |||
| $(DOCKER_TELEMETRY)_RUN_OPT += -t | |||
| $(DOCKER_TELEMETRY)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro | |||
| $(DOCKER_TELEMETRY)_RUN_OPT += -v /etc/timezone:/etc/timezone:ro | |||
| ifneq ($(INCLUDE_SYSTEM_GNMI), y) | |||
| $(DOCKER_TELEMETRY)_RUN_OPT += -v /var/run/dbus:/var/run/dbus:rw | |||
| endif | |||
There was a problem hiding this comment.
When we disable GNMI and enable TELEMETRY like 202305 branch, telemetry needs to access dbus to support GNMI native feature.
There was a problem hiding this comment.
I am not sure your goal on 202305 public repo. Is it single telemetry container or single gnmi container.
The same question is applicable to all the branch on public repos.
There was a problem hiding this comment.
We have reverted all the changes on 202305 public repo, and I will only change master public repo.
For master public repo, it's single gnmi container.
lguohan
reviewed
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We have below requirements:
Need to share docker image for telemetry and gnmi for 202305 and master branch.
Need single telemetry container for 202305 branch.
Need single gnmi container for master branch.
I was using docker-sonic-gnmi as base, but this implementation does not work for single telemetry container. So I add a new base gnmi docker image for gnmi and telemetry.
close #17978
Work item tracking
How I did it
Add a new base gnmi docker image, and build telemetry and gnmi image on this new image.
And I also rename telemetry.mk, telemetry.dep and SONIC_TELEMETRY.
How to verify it
Run end to end test for gnmi and telemetry.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)