-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[device/accton]:Update Accton-AS7816-64X #1691
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Accton-AS7816-64X to adapt xxx.config.bcm based on the latest update of `Device-Specific File Directory Structure` Signed-off-by: [email protected]
@pollyhsu2git, can you resolve conflict? |
@lguohan |
it does not look like we still need this pr, @pollyhsu2git ? if yes, can you resolve the conflict? |
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jun 29, 2021
186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672) 7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640) 38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658) c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691) 57dc403 [ci]: Fix config prompt question issue (sonic-net#1693) Signed-off-by: Stephen Sun <[email protected]>
jleveque
pushed a commit
that referenced
this pull request
Jun 30, 2021
186d851 Pcieutil to load the platform api first instead of using common api (#1672) 7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640) 38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658) c5d00ae [pfcwd] Fix the return code in invalid case (#1691) 57dc403 [ci]: Fix config prompt question issue (#1693) Signed-off-by: Stephen Sun <[email protected]>
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 17, 2021
List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (#1630)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672) 7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640) 38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658) c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691) 57dc403 [ci]: Fix config prompt question issue (sonic-net#1693) Signed-off-by: Stephen Sun <[email protected]>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (sonic-net#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (sonic-net#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (sonic-net#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (sonic-net#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (sonic-net#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (sonic-net#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (sonic-net#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (sonic-net#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (sonic-net#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (sonic-net#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (sonic-net#1630)
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
Signed-off-by: Neetha John <[email protected]> Fixes sonic-net#1690 What I did Set the correct return code when pfcwd command is specified with invalid options How to verify it Modified the unit test to check for the correct return code and ran them and they passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device-Specific File Directory Structure
Signed-off-by: [email protected]
- What I did
Update Accton-AS7816-64X to adapt xxx.config.bcm based on the latest update of
Device-Specific File Directory Structure
the SONiC Porting Guide- How I did it
Add config.bcm based on the latest update of
Device-Specific File Directory Structure
the SONiC Porting Guide (https://github.com/Azure/SONiC/wiki/Porting-Guide)- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)