Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:16114] Remove depot_tools repo #16408

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

mssonicbld
Copy link
Collaborator

Why I did it

It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. The sonic-p4rt code runs bazel, which means this depot_tools version would get called instead of the regular system-installed version.

Rather than going through the process of setting up/installing vpython3, just get rid of this repo.

Fixes #16087.

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

It appears that this was initially added to provide the git-retry
command (which doesn't appear to be used today). However, this repo is
now also providing bazel (which is actually used in our build today),
and this command (along with git-retry) expects some vpython3 binary to
be set up/installed.

Rather than going through that, just get rid of this repo.
@mssonicbld mssonicbld requested a review from lguohan as a code owner September 3, 2023 03:23
@mssonicbld mssonicbld mentioned this pull request Sep 3, 2023
11 tasks
@mssonicbld
Copy link
Collaborator Author

Original PR: #16114

@mssonicbld mssonicbld merged commit dc39913 into sonic-net:202305 Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants