[monit][dualtor] Periodically check mux neighbors consistency #15769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <[email protected]>
prsunny
reviewed
Jul 10, 2023
| # dualtor_neighbor_check.py: script to check if the neighbor entries in APPL_DB | ||
| # has correct neighbor or tunnel route entries in ASIC_DB based on the mux | ||
| # states. | ||
| check program dualtorNeighborCheck with path "/usr/local/bin/dualtor_neighbor_check.py -o SYSLOG -s ERROR" |
There was a problem hiding this comment.
looking at routeCheck above, there is no -o or -s option. Why do we need to explicitly set here?
There was a problem hiding this comment.
Those arguments are to set the log output destination(-o) and log level(-s)
prsunny
approved these changes
Jul 14, 2023
|
/azp run |
|
Commenter does not have sufficient privileges for PR 15769 in repo sonic-net/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @prsunny, could you please help merge it? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2023
…net#15769) Signed-off-by: Longxiang Lyu <[email protected]>
|
Cherry-pick PR to 202211: #15953 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2023
…net#15769) Signed-off-by: Longxiang Lyu <[email protected]>
|
Cherry-pick PR to 202205: #15954 |
This was referenced Jul 25, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 6, 2023
…net#15769) Signed-off-by: Longxiang Lyu <[email protected]>
|
Cherry-pick PR to 202305: #16055 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 8, 2023
Signed-off-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
yxieca
pushed a commit
that referenced
this pull request
Aug 10, 2023
#15954) Signed-off-by: Longxiang Lyu <[email protected]> Co-authored-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
2 similar comments
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…net#15769) Signed-off-by: Longxiang Lyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This depends on PR sonic-net/sonic-utilities#2840.
And it is to enable
dualtor_neighbor_check.pyas a periodical check.Work item tracking
How I did it
How to verify it
Verify on testbed, for any inconsistencies,
monitwill writeERRORsyslogs:Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)