Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule update for sonic-mgmt-common and sonic-gnmi #15519

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

sachinholla
Copy link
Contributor

@sachinholla sachinholla commented Jun 16, 2023

Why I did it

Updating submodule references for sonic-mgmt-common and sonic-gnmi together.
Cannot update them individually due to compilation dependency. Automatic submodule update jobs are failing.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Updated submodules to include following commits:

sonic-mgmt-common:

38eef09 Fix memleaks in cvl (#95)
f24fc03 Translib APIs for subscription (#92)

sonic-gnmi:

01fe667 Merge pull request #134 from FengPan-Frank/fenpan_dialout_rename
994c69c Rename --enable-dialout option into ENABLE_DIALOUT to follow the convention.
a9126da Update makefile to support armhf (#132)
0d80c0d prevent potential panic: return immediately if there exists error (#113)
3c0fca3 Merge pull request #131 from FengPan-Frank/fenpan_dialout
c3d3266 Add build flag into gnmi as --enable-dialout.
fd78c42 add semgrep (#126)
214fa1c TranslClient: Use new translib subscription APIs (#122)
87d8eb3 TranslClient: use PathValidator to sanitize the request paths (#112)

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@sachinholla sachinholla requested a review from lguohan as a code owner June 16, 2023 23:58
@adyeung adyeung requested a review from qiluo-msft June 21, 2023 19:03
@sachinholla sachinholla force-pushed the subscribe_submod branch 2 times, most recently from c76d947 to 1ebb1e6 Compare July 5, 2023 16:36
@adyeung
Copy link
Collaborator

adyeung commented Jul 5, 2023

@lguohan @qiluo-msft Submitter will rebase to sync the branch, if you don't have any concerns about this change, I will request repo maintainer to merge

@qiluo-msft
Copy link
Collaborator

Could you added into PR description the commits included by submodule moving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants