[BFN]: Implement getting psu related sensors in sonic_platform directly from BMC #12786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokhan
approved these changes
Nov 21, 2022
|
@qiluo-msft , @prgeor , @richardyu-ms, please approve and merge |
5 similar comments
|
@qiluo-msft , @prgeor , @richardyu-ms, please approve and merge |
|
@qiluo-msft , @prgeor , @richardyu-ms, please approve and merge |
|
@qiluo-msft , @prgeor , @richardyu-ms, please approve and merge |
|
@qiluo-msft , @prgeor , @richardyu-ms, please approve and merge |
|
@qiluo-msft , @prgeor , @richardyu-ms, please approve and merge |
|
@StormLiangMS , could you please take a look? Thank you in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Platform interface doesn't provide all sensors and using it isn't effective
How I did it
Request sensors via http from BMC server and parse the result
How to verify it
Related daemon in pmon populates redis db, run this command to view the contents
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)