[Barefoot] Add xon_offset to pg_profile_lookup.ini #12073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Why I did it Barefoot uses hysteresis, instead of 'xon-threshold'. 'xon' is only supported in static mode, so there is a need to add this attribute to every mode in PG profile init file - How I did it 'xon_offset' was added to pg_profile_lookup.ini - How to verify it Install and basic sanity tests including traffic. Checked with: pfcwd/test_pfc_config.py pfcwd/test_pfcwd_all_port_storm.py pfcwd/test_pfcwd_function.py pfcwd/test_pfcwd_war_reboot.py pfc_asym/test_pfc_asym.py Signed-off-by: Mariusz Stachura <[email protected]>
|
Commenter does not have sufficient privileges for PR 12073 in repo sonic-net/sonic-buildimage |
|
@prsunny Hey Prince, do you think there might be some CI issues lately? I keep getting different errors here, many thanks in advance. |
|
Hi @xumia, I think that those CI issues are not related to my change. Could you help me out finding a solution to get this PR merged? Many thanks in advance |
SavchukRomanLv
pushed a commit
to SavchukRomanLv/sonic-buildimage
that referenced
this pull request
Nov 1, 2022
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Barefoot uses hysteresis, instead of 'xon-threshold'. 'xon' is only supported in static mode, so there is a need to add this attribute to every mode in PG profile init file
How I did it
'xon_offset' was added to pg_profile_lookup.ini
How to verify it
Install and basic sanity tests including traffic.
Checked with:
pfcwd/test_pfc_config.py pfcwd/test_pfcwd_all_port_storm.py pfcwd/test_pfcwd_function.py pfcwd/test_pfcwd_war_reboot.py pfc_asym/test_pfc_asym.py
Signed-off-by: Mariusz Stachura [email protected]