Add YANG model and unit tests for sonic-telemetry #10840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update configuration.md with telemetry table * Update configuration.md header * Update Configuration.md * Update configuration.md spacing
qiluo-msft
reviewed
May 17, 2022
|
|
||
| leaf ca_crt { | ||
| type string { | ||
| pattern '(/[a-zA-Z0-9_-]+)*/dsmsroot.cer'; |
There was a problem hiding this comment.
According to:
All telemetry certs will have the exact path listed. Maybe it makes sense to enforce the entire path instead of just the file name and extension.
There was a problem hiding this comment.
The file name must be dsmsroot.cer? Can we use other name like abc.cer?
There was a problem hiding this comment.
Changed pattern to not include filename in the case that file name changes in the future.
qiluo-msft
reviewed
May 17, 2022
| "sonic-telemetry:TELEMETRY": { | ||
| "certs": { | ||
| "ca_crt": "/etc/sonic/telemetry/dsmsroot.cer", | ||
| "server_crt": "/etc/sonic/telemetry/streamingtelemetryserver.cer", |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=6)
Mixing tabs/spaces. Prefer 4-space indentation. #Closed
qiluo-msft
reviewed
May 17, 2022
| "eStrKey": "InvalidValue" | ||
| }, | ||
| "TELEMETRY_TABLE_WITH_VALID_CONFIG": { | ||
| "desc": "TABLE WITH VALID CONFIG." |
qiluo-msft
reviewed
May 17, 2022
| * [Versions](#versions) | ||
| * [TC to Queue map](#tc-to-queue-map) | ||
| * [Telemetry](#telemetry) | ||
| * [Versions](#versions) |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=32&length=4)
Do not add unnecessary trailing blanks. #Closed
* Replace tabs for 4 spaces * Replace tabs for 4 spaces in telemetry file Co-authored-by: Ubuntu <zain@zb-dev-vm.022x1jpnpm4u1iy2d325acts3c.yx.internal.cloudapp.net>
ganglyu
approved these changes
May 19, 2022
qiluo-msft
approved these changes
May 19, 2022
hui-ma
approved these changes
May 20, 2022
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 20, 2022
…anch Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
YANG schema is missing for sonic-telemetry
How I did it
Added YANG schema and unit tests
How to verify it
Build sonic-yang-models python wheels target
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix #10552
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)