Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build will fail when working on a branch name with "/" #514

Closed
taoyl-ms opened this issue Apr 18, 2017 · 3 comments
Closed

Build will fail when working on a branch name with "/" #514

taoyl-ms opened this issue Apr 18, 2017 · 3 comments
Assignees

Comments

@taoyl-ms
Copy link
Contributor

taoyl-ms commented Apr 18, 2017

git_revision will contain "/", and later sed will fail.

Example log:

Build ONIE installer
+ arch=x86_64
+ machine=broadcom
+ platform=x86_64-broadcom-r0
+ installer_dir=installer
+ platform_conf=platform/broadcom/platform.conf
+ output_file=target/sonic-broadcom.bin
+ demo_type=OS
+ git_revision=taoyl/test.0-c8a315e
+ onie_image_part_size=32768
+ shift 9
+ [ ! -d installer ]
+ [ ! -r installer/sharch_body.sh ]
+ [ ! -d installer/x86_64 ]
+ [ ! -r installer/x86_64/install.sh ]
+ [ -n taoyl/test.0-c8a315e ]
+ [ -n 32768 ]
+ [ -r platform/broadcom/platform.conf ]
+ [ 1 -gt 0 ]
+ tmp_dir=
+ echo -n Building self-extracting install image .
Building self-extracting install image .+ mktemp --directory
+ tmp_dir=/tmp/tmp.85lbt3lbEE
+ tmp_installdir=/tmp/tmp.85lbt3lbEE/installer
+ mkdir /tmp/tmp.85lbt3lbEE/installer
+ cp -r installer/x86_64/install.sh installer/x86_64/macset.sh installer/x86_64/platforms /tmp/tmp.
85lbt3lbEE/installer
+ cp onie-image.conf /tmp/tmp.85lbt3lbEE/installer
+ echo
+ sed -e s/[\/&]/\\&/g
+ EXTRA_CMDLINE_LINUX=
+ sed -i -e s/%%DEMO_TYPE%%/OS/g -e s/%%GIT_REVISION%%/taoyl/test.0-c8a315e/g -e s/%%ONIE_IMAGE_PART
_SIZE%%/32768/ -e s/%%EXTRA_CMDLINE_LINUX%%// /tmp/tmp.85lbt3lbEE/installer/install.sh
sed: -e expression #2, char 26: unknown option to `s'
+ clean_up 1
+ rm -rf /tmp/tmp.85lbt3lbEE
+ exit 1
slave.mk:314: recipe for target 'target/sonic-broadcom.bin' failed
make: Leaving directory '/sonic'
make: *** [target/sonic-broadcom.bin] Error 1
Makefile:33: recipe for target 'target/sonic-broadcom.bin' failed
make: *** [target/sonic-broadcom.bin] Error 2
@lguohan
Copy link
Collaborator

lguohan commented Apr 18, 2017

treat this an improvement.

@lguohan
Copy link
Collaborator

lguohan commented May 24, 2017

@qiluo-msft, is this issue fixed? If yes, can you link this issue to the PR?

@qiluo-msft
Copy link
Collaborator

Fixed in 2cfa289
Please let me know if you can repro this issue.

lguohan added a commit to lguohan/sonic-buildimage that referenced this issue Oct 9, 2019
* 1f4a1d7 2019-09-24 | Add warm boot support with removed/created port (sonic-net#515) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik]
* 59e530a 2019-09-20 | Add support for debug counters (sonic-net#517) [Danny Allen]
* 1ed09e0 2019-09-20 | fully support bulk_remove in sairedis (sonic-net#516) [Dong Zhang]
* 6cb1b31 2019-09-17 | Add support for port remove and port create (no warm boot) (sonic-net#500) [Kamil Cudnik]
* 83d86ed 2019-09-17 | Fix c_str() in printf for string (sonic-net#514) [Kamil Cudnik]
* 11b44b5 2019-09-16 | Advance SAI reference pointer to v1.5.0 (sonic-net#509) [Wenda Ni]
* 38c6945 2019-09-14 | support sflow on virtual switch (sonic-net#498) [Rakesh Datta]
* e7d766e 2019-09-09 | Add acl counter match logic based on acl entry field (sonic-net#511) [Kamil Cudnik]
* 58845ce 2019-09-06 |  Add extra check for warm boot discovered RIDs (sonic-net#502) [Kamil Cudnik]
* b4893ef 2019-09-05 | [flex counter]: Lower the severity of log during rif counter support check (sonic-net#504) [shikenghua]
* b859344 2019-09-03 | fix found typo in new added syncMode related codes (sonic-net#506) [Dong Zhang]

Signed-off-by: Guohan Lu <[email protected]>
lguohan added a commit that referenced this issue Oct 18, 2019
[submodule]: update sonic-sairedis

1f4a1d7 2019-09-24 | Add warm boot support with removed/created port (#515) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik]
59e530a 2019-09-20 | Add support for debug counters (#517) [Danny Allen]
1ed09e0 2019-09-20 | fully support bulk_remove in sairedis (#516) [Dong Zhang]
6cb1b31 2019-09-17 | Add support for port remove and port create (no warm boot) (#500) [Kamil Cudnik]
83d86ed 2019-09-17 | Fix c_str() in printf for string (#514) [Kamil Cudnik]
11b44b5 2019-09-16 | Advance SAI reference pointer to v1.5.0 (#509) [Wenda Ni]
38c6945 2019-09-14 | support sflow on virtual switch (#498) [Rakesh Datta]
e7d766e 2019-09-09 | Add acl counter match logic based on acl entry field (#511) [Kamil Cudnik]
58845ce 2019-09-06 | Add extra check for warm boot discovered RIDs (#502) [Kamil Cudnik]
b4893ef 2019-09-05 | [flex counter]: Lower the severity of log during rif counter support check (#504) [shikenghua]
b859344 2019-09-03 | fix found typo in new added syncMode related codes (#506) [Dong Zhang]

also update broadcom and mellanox SAI
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this issue Aug 31, 2020
qiluo-msft added a commit that referenced this issue Sep 15, 2021
…pdate submodule sonic-swss-common (#8513)

#### Why I did it
Backport #8034 to 202012 branch

sonic-swss-common submodule updating includes below commits
```
a6b98da 2021-04-29 | Add support for config_db subscribe and unsubscribe python apis (#481) [arlakshm]
2506ca0 2021-08-22 | [ci] Fix azure pipeline DownloadPipelineArtifact source branch (#514) [Qi Luo]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants