The NTP_SERVER configuration generated from the minigraph doesn't meet the new schema requirements.

[oleksandrivantsiv]

Description

The NTP_SERVER configuration generated from the minigraph doesn't meet the new schema requirements.

The issue is caused by the changes introduced in [NTP] Add NTP extended configuration PR. The PR updates the config DB schema and makes the NTP configuration generated from the minigraph incompatible.

Steps to reproduce the issue:

1. Add NTP servers configuration to the minigraph file:

          <a:DeviceProperty>
            <a:Name>NtpResources</a:Name>
            <a:Reference i:nil="true"/>
            <a:Value>10.210.25.32;10.75.202.2</a:Value>
          </a:DeviceProperty>

2. Run sonic-cfggen utility generate config DB configuration from the minigraph:

sonic-cfggen -m /etc/sonic/minigraph.xml  --print-data

Describe the results you received:

The utility generates the NTP_SERVER configuration in the following format:

    "NTP_SERVER": {
        "10.210.25.32": {},
        "10.75.202.2": {}
    },

As a result, the NTP feature ignores this configuration, and the time synchronization doesn't work:

# show ntp
MGMT_VRF_CONFIG is not present.
unsynchronised
   polling server every 1 s

Describe the results you expected:

The NTP feature implementation expects to have an extended configuration in the format like this:

    "NTP_SERVER": {
        "internal_ntp_server1": {
            "association_type": "server",
            "iburst": "on",
            "admin_state": "enabled",
            "version": 3,
            "resolve_as": "10.210.25.32"
       },
        "internal_ntp_server2": {
            "association_type": "server",
            "iburst": "on",
            "admin_state": "enabled",
            "version": 3,
            "resolve_as": "10.75.202.2"
       },
    },

The YANG model for the configuration is defined here sonic-ntp.yang

Output of show version:

# show version

SONiC Software Version: SONiC.master.560-c274be2e5_Internal
SONiC OS Version: 12
Distribution: Debian 12.4
Kernel: 6.1.0-11-2-amd64
Build commit: c274be2e5
Build date: Mon Jan 22 21:57:27 UTC 2024
Built by: sw-r2d2-bot@r-build-sonic-ci02-244

Platform: x86_64-mlnx_msn4700-r0
HwSKU: Mellanox-SN4700-O28
ASIC: mellanox
ASIC Count: 1
Serial Number: MT2247XZ0588
Model Number: MSN4700-WS2F
Hardware Revision: A1
Uptime: 02:17:59 up  1:25,  1 user,  load average: 0.41, 0.32, 0.35
Date: Fri 26 Jan 2024 02:17:59

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

[gechiang]

@fastiuk , please help fix this as the PR you raised seems to be the root cause of this issue.

[fastiuk]

@fastiuk , please help fix this as the PR you raised seems to be the root cause of this issue.

@gechiang do you know what is the due date to fix this issue?

[gechiang]

@fastiuk , I would say as soon as possible as this is a regression and impacting the community.

[saiarcot895]

This issue is present on both master and 202311 branch.

[fastiuk]

Due date is Apr 12

[fastiuk]

WIP on that issue. Any way to move it to the "In progress" state, or there is no such thing on GitHub?