Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfputil broken for multiple platforms #1037

Closed
rodnymolina opened this issue Oct 12, 2017 · 6 comments
Closed

sfputil broken for multiple platforms #1037

rodnymolina opened this issue Oct 12, 2017 · 6 comments
Assignees
@jleveque
Labels
Bug 🐛

Comments

@rodnymolina
Copy link
Contributor

Due to the recent changes in sfputil code, support for cli commands like "show interfaces transceiver" may be broken for a bunch of platforms. Some refactoring is needed for most of these files:

rmolina@server04:~/wsp_oct_6_2017/sonic-buildimage$ ls -lrt device///plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 4940 Oct 6 22:09 device/accton/x86_64-accton_as5712_54x-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 265 Oct 6 22:09 device/arista/x86_64-arista_7260cx3_64/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 265 Oct 6 22:09 device/arista/x86_64-arista_7060_cx32s/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 265 Oct 6 22:09 device/arista/x86_64-arista_7050_qx32s/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 265 Oct 6 22:09 device/arista/x86_64-arista_7050_qx32/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 1372 Oct 6 22:09 device/accton/x86_64-accton_as7712_32x-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 722 Oct 6 22:09 device/accton/x86_64-accton_as7512_32x-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 6514 Oct 6 22:09 device/ingrasys/x86_64-ingrasys_s8900_54xc-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 4191 Oct 6 22:09 device/ingrasys/x86_64-ingrasys_s8810_32q-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 1319 Oct 6 22:09 device/dell/x86_64-dell_z9100_c2538-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 755 Oct 6 22:09 device/dell/x86_64-dell_s6100_c2538-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 4984 Oct 6 22:09 device/dell/x86_64-dell_s6000_s1220-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 1301 Oct 6 22:09 device/mellanox/x86_64-mlnx_msn2740-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 1301 Oct 6 22:09 device/mellanox/x86_64-mlnx_msn2700-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 1301 Oct 6 22:09 device/mellanox/x86_64-mlnx_msn2410-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 1301 Oct 6 22:09 device/mellanox/x86_64-mlnx_msn2100-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 1329 Oct 6 22:09 device/inventec/x86_64-inventec_d7032q28b-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 6369 Oct 6 22:09 device/ingrasys/x86_64-ingrasys_s9100-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 7177 Oct 6 22:09 device/ingrasys/x86_64-ingrasys_s8900_64xc-r0/plugins/sfputil.py
-rw-rw-r-- 1 rmolina rmolina 729 Oct 10 13:16 device/celestica/x86_64-cel_seastone-r0/plugins/sfputil.py

I recently fixed Celestica (#1022), but others require some work.
@stcheng
Copy link
Contributor

stcheng commented Oct 13, 2017

thanks for reporting this bug

@jleveque
Copy link
Contributor

jleveque commented Dec 5, 2017 •
edited
Loading

As of today, it appears that only the following plugin has not yet been updated to adapt to the new API design:

device/accton/x86_64-accton_as7512_32x-r0/plugins/sfputil.py

@jleveque
Copy link
Contributor

jleveque commented Mar 3, 2018

Just checked again, and it appears there are now three platforms which have sfputil plugins that do not conform with the new API:

  • device/x86_64-accton_as7512_32x-r0/plugins/sfputil.py
  • device/x86_64-accton_as7212_54x-r0/plugins/sfputil.py
  • device/x86_64-marvell_slm5401_54x-r0/plugins/sfputil.py

@ziverlich / @NStetskovych: Could you please update these plugins to work with the new API so that we can close this issue?

@ziverlichson
Copy link
Contributor

Hi @jleveque ,
PR #1456 made with the relevant updates.

@NStetskovych-zz
Copy link
Contributor

Will adapt sfputil for new API.

@NStetskovych-zz NStetskovych-zz mentioned this issue Mar 12, 2018
Merged
@jleveque
Copy link
Contributor

@ziverlich, @NStetskovych: Thank you for the quick turnaround to get this resolved.

@prsunny prsunny mentioned this issue Oct 18, 2019
Merged
lguohan pushed a commit that referenced this issue Oct 20, 2019
@prsunny @lguohan
[Submodule] Update sonic-swss-common and sonic-swss (#3626)
07235d0 
Sonic-swss-common:

aaa8133 - 2019-10-12 : Add VRF object table in state_db (#312) [Tyler Li]
91aceb1 - 2019-10-11 : [schema] Update schema to support debug counters (#308) [Danny Allen]
9bcd5ca - 2019-09-28 : [multi-DB] fix vs test, should NOT replace old DBConnector API with new DBConnector API since vs test docker has no database_config.josn (#311) [Dong Zhang]
599155a - 2019-09-25 : [multi-DB] Part 2: C++ interface API changes / swsscommon unit test / LOGLEVEL_DB apply new API (#301) [Dong Zhang]
379ac73 - 2019-09-20 : add bulkremove for consumer_table_pops.lua (#306) [Dong Zhang]
6b805d3 - 2019-09-19 : timerfd return 0 with errno =0 - handle as False alarm. (#302) [Renuka Manavalan]
e455891 - 2019-09-03 : Add VLAN_SUB_INTERFACE in CONFIG_DB schema (#284) [Wenda Ni]

Sonic-swss

731a8f5 - 2019-10-17 : [copporch]: fix the endless loop problem when removing copp table group. (#1038) [wangshengjun]
1623219 - 2019-10-14 : Enable C++ unit test during build (#1092) [Qi Luo]
629c9d3 - 2019-10-14 : [vstest]: Revert back to 2 sec, and check if we got more than expected number of syslogs (#1091) [Prince Sunny]
80b2ace - 2019-10-11 : sonic-swss/orchagent: Add new protocol trap name support (#1087) [jpxjlrldgit]
9f765f7 - 2019-10-11 : [aclorch]: Check for existing mirror table only when creating a new table (#1089) [Danny Allen]
4c10260 - 2019-10-11 : [vstest]: Update Route test to check for added entry (#1088) [Prince Sunny]
e658b64 - 2019-10-11 : [chassisorch]: Add everflow feature for chassis (#1024) [Ze Gan]
5b13387 - 2019-10-10 : [changelog]: Revert changelog that was done for passing VS test. (#1080) [Prince Sunny]
90a690d - 2019-10-10 : [aclorch]: Simplify the TCP flags matching code and support exact value match (#1072) [Shuotian Cheng]
3461710 - 2019-10-09 : Single VRF for ingress and egress flows, skip route replication (#1045) [Prince Sunny]
953474a - 2019-10-03 : [swss]: Do not use namespace in header files (#1081) [Wenda Ni]
bd36751 - 2019-10-03 : Change nexthop key to ip & ifname (#977) [tylerlinp]
fee1aaa - 2019-10-02 : [teamsyncd]: Check if LAG exists before removing (#1069) [Shuotian Cheng]
175f3de - 2019-09-30 : Update ECMP NHopGroup for Port Channel oper down (#1030) [Sumukha Tumkur Vani]
182940d - 2019-09-26 : [mirrororch]: Remove mirror session state after it is remvoed (#1066) [Shuotian Cheng]
d823dd1 - 2019-09-20 : [MirrorOrch]: Mirror Session Retention across Warm Reboot (#1054) [Shuotian Cheng]
a5b6e7c - 2019-09-19 : Ignore link local neighbors (#1065) [Prince Sunny]
0ddaba3 - 2019-09-19 : Adopt to signature change of Selectable::readData, which switched (#1061) [Renuka Manavalan]
543bd98 - 2019-09-18 : [aclorch]: Fix table name in counter table for mirror rules (#1060) [Shuotian Cheng]
12c29b4 - 2019-09-19 : Cannot ping to link-local ipv6 interface address of the switch. (#774) [Kiran Kumar Kella]
4d8e08d - 2019-09-18 : change in fpmsyncd to skip the lookup for the Master device name if the route object table value is zero (#1048) [Arvindsrinivasan Lakshmi narasimhan]
da514f5 - 2019-09-18 : Do not update lag mtu from teamsyncd (netlink) (#1053) [Prince Sunny]
3fb22e1 - 2019-09-16 : Check warmboot flag during initialization (#1057) [Prince Sunny]
d98d1e9 - 2019-09-16 : [aclorch]: Egress mirror action support and action ASIC support check (#963) [Stepan Blyshchak]
313ef5c - 2019-09-09 : Warmboot Vlan neigh restore fix (#1040) [Prince Sunny]
5841e06 - 2019-09-06 : Add dot1p to tc mapping support (#871) [Wenda Ni]
39fe568 - 2019-08-30 : [aclorch]: Revise ACL rule creation/removal logs (#1042) [Shuotian Cheng]
c461911 - 2019-08-27 : [copporch]: Fix the typo - mld_v1_done (#1037) [wangshengjun]
34915de - 2019-08-22 : [portsyncd]: Add default catch block in portsyncd (#1033) [SuvarnaMeenakshi]
dc81a21 - 2019-08-20 : [vnet]: Fix FDB related failure in "vnet_bitmap" virtual switch test (#1034) [Volodymyr Samotiy]
5ae4226 - 2019-08-19 : [test]: Adjust stale timer for warm-reboot neighborsync test cases (#1031) [zhenggen-xu]
65cbd55 - 2019-08-16 : [build]: Fix compiling warnings using ARM 32 bit compiler (#1015) [[email protected]]
b611808 - 2019-08-16 : [Orchagent]: Fixbug segmentfault at routeorch (#1025) [Ze Gan]
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@wangshengjun @stcheng
[copporch]: Fix the typo - mld_v1_done (sonic-net#1037)
c461911 
Signed-off-by: wangshengjun <[email protected]>
stephenxs pushed a commit to stephenxs/sonic-buildimage that referenced this issue Aug 14, 2020
[submodule] Advance submodule head for sonic-utilities
9d272ae 
    [db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (sonic-net#993)
    [show/vlan]: fix show vlan config (sonic-net#1050)
    [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018)
    [config] Eliminate port breakout-related globals (sonic-net#1045)
    [teamshow]: refactor teamshow to use state db information (sonic-net#1049)
    [watermarkstat] Import print_function from __future__ (sonic-net#1048)
    [show]: split show interfaces commands into separate file (sonic-net#1044)
    Python 3 compliance (sonic-net#1043)
    Update all references to new 'sonic-installer' file name (sonic-net#1033)
    [config/show]: split vlan into separate file (sonic-net#1038)
    [pytest/coverage]: add coverage for all scripts (sonic-net#1041)
    enable watchdog before running platform specific reboot plugin (sonic-net#1037)
    [tests]:add coverage for config/main/utilities_common module (sonic-net#1039)
    [cli/feature]: split feature command into a separate file (sonic-net#1034)

Signed-off-by: Stephen Sun <[email protected]>
lguohan pushed a commit that referenced this issue Aug 14, 2020
@stephenxs
[submodule] Advance submodule head for sonic-utilities (#5184)
5c02078 
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (#993)
    [show/vlan]: fix show vlan config (#1050)
    [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (#1018)
    [config] Eliminate port breakout-related globals (#1045)
    [teamshow]: refactor teamshow to use state db information (#1049)
    [watermarkstat] Import print_function from __future__ (#1048)
    [show]: split show interfaces commands into separate file (#1044)
    Python 3 compliance (#1043)
    Update all references to new 'sonic-installer' file name (#1033)
    [config/show]: split vlan into separate file (#1038)
    [pytest/coverage]: add coverage for all scripts (#1041)
    enable watchdog before running platform specific reboot plugin (#1037)
    [tests]:add coverage for config/main/utilities_common module (#1039)
    [cli/feature]: split feature command into a separate file (#1034)

Signed-off-by: Stephen Sun <[email protected]>

Co-authored-by: Stephen Sun <[email protected]>
abdosi added a commit that referenced this issue Sep 3, 2020
@abdosi
[submodule update] sonic-util
c480db1 
Fix error when running 'show lldp table' or 'show lldp neighbor'
through SSH command. (#1067)
[201911]: Multi asic show interface support (#1070)
[counterpoll] Add new FC group for port buffer drop counters
(#1024)
[201911] show interface portchannel support for Multi ASIC
(#1071)
Fix a typo in mellanox_buffer_migrator (#1090)
Fix pfcwd stats crash with invalid queue name (#1077)
[PFCWD] Fix issue with "pfcwd show stats" command during SONiC init
(#1018)
enable watchdog before running platform specific reboot plugin
(#1037)
Add namespace of the process in the coredump filename. (#1091)
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this issue Feb 25, 2021
@stephenxs @santhosh-kt
[submodule] Advance submodule head for sonic-utilities (sonic-net#5184)
02db790 
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (sonic-net#993)
    [show/vlan]: fix show vlan config (sonic-net#1050)
    [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018)
    [config] Eliminate port breakout-related globals (sonic-net#1045)
    [teamshow]: refactor teamshow to use state db information (sonic-net#1049)
    [watermarkstat] Import print_function from __future__ (sonic-net#1048)
    [show]: split show interfaces commands into separate file (sonic-net#1044)
    Python 3 compliance (sonic-net#1043)
    Update all references to new 'sonic-installer' file name (sonic-net#1033)
    [config/show]: split vlan into separate file (sonic-net#1038)
    [pytest/coverage]: add coverage for all scripts (sonic-net#1041)
    enable watchdog before running platform specific reboot plugin (sonic-net#1037)
    [tests]:add coverage for config/main/utilities_common module (sonic-net#1039)
    [cli/feature]: split feature command into a separate file (sonic-net#1034)

Signed-off-by: Stephen Sun <[email protected]>

Co-authored-by: Stephen Sun <[email protected]>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
@sujinmkang
enable watchdog before running platform specific reboot plugin (sonic…
33ba594 
…-net#1037)
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this issue Jul 22, 2022
@vmittal-msft
Updated SAI submodule to pick few fixes from master (sonic-net#1037)
f67bcdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleveque jleveque

Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stcheng @jleveque @rodnymolina @NStetskovych-zz @ziverlichson