Taking care of review comments and fixing the LGTM alerts

sonic-net · Nov 5, 2020 · c14b93a · c14b93a
1 parent 9547b1c
commit c14b93a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 20 deletions.
diff --git a/platform/pddf/i2c/utils/pddfparse.py b/platform/pddf/i2c/utils/pddfparse.py
@@ -971,25 +971,24 @@ def show_led_device(self, key, ops):
             KEY='led'
             if not KEY in self.sysfs_obj:
                 self.sysfs_obj[KEY] = []
-                    path="pddf/devices/led"
-                    for attr in self.data[key]['i2c']['attr_list']:
-                        self.sysfs_attr('device_name', self.data[key]['dev_info']['device_name'], path, 
-                                self.sysfs_obj, KEY)
-                        self.sysfs_attr('swpld_addr', self.data[key]['dev_info']['device_name'], path, 
-                                self.sysfs_obj, KEY)
-                        self.sysfs_attr('swpld_addr_offset', self.data[key]['dev_info']['device_name'], path, 
-                                self.sysfs_obj, KEY)
-                        self.sysfs_device(self.data[key]['dev_attr'], path, self.sysfs_obj, KEY)
-                        for attr_key in attr.keys():
-                                attr_path="pddf/devices/led/" + attr['attr_name']
-                                if (attr_key != 'attr_name' and attr_key != 'swpld_addr' and 
-                                        attr_key != 'swpld_addr_offset'):
-                                        self.sysfs_attr(attr_key, attr[attr_key], attr_path, self.sysfs_obj, KEY)
-                    sysfs_path="/sys/kernel/pddf/devices/led/dev_ops"
-                    if not sysfs_path in self.sysfs_obj[KEY]:
-                            self.sysfs_obj[KEY].append(sysfs_path)
-                    list=['/sys/kernel/pddf/devices/led/cur_state/color']
-                    self.add_list_sysfs_obj(self.sysfs_obj, KEY, list)
+                path="pddf/devices/led"
+                for attr in self.data[key]['i2c']['attr_list']:
+                    self.sysfs_attr('device_name', self.data[key]['dev_info']['device_name'], path, 
+                            self.sysfs_obj, KEY)
+                    self.sysfs_attr('swpld_addr', self.data[key]['dev_info']['device_name'], path, 
+                            self.sysfs_obj, KEY)
+                    self.sysfs_attr('swpld_addr_offset', self.data[key]['dev_info']['device_name'], path, 
+                            self.sysfs_obj, KEY)
+                    self.sysfs_device(self.data[key]['dev_attr'], path, self.sysfs_obj, KEY)
+                    for attr_key in attr.keys():
+                        attr_path="pddf/devices/led/" + attr['attr_name']
+                        if (attr_key != 'attr_name' and attr_key != 'swpld_addr' and attr_key != 'swpld_addr_offset'):
+                            self.sysfs_attr(attr_key, attr[attr_key], attr_path, self.sysfs_obj, KEY)
+                sysfs_path="/sys/kernel/pddf/devices/led/dev_ops"
+                if not sysfs_path in self.sysfs_obj[KEY]:
+                    self.sysfs_obj[KEY].append(sysfs_path)
+                list=['/sys/kernel/pddf/devices/led/cur_state/color']
+                self.add_list_sysfs_obj(self.sysfs_obj, KEY, list)
 
 
     def validate_xcvr_device(self, dev, ops):

diff --git a/platform/pddf/platform-api-pddf-base/sonic_platform_ref/__init__.py b/platform/pddf/platform-api-pddf-base/sonic_platform_ref/__init__.py
@@ -1,4 +1,7 @@
 # All the derived classes for PDDF
 __all__ = ["platform", "chassis", "sfp", "psu", "thermal"]
 
-from sonic_platform import *
+# Commenting the below code as this just for the reference for the ODMs.
+# It can be uncommented when this reference code is used
+
+#from sonic_platform import *