bgp error handling changes for review on master branch #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-aviz
reviewed
Sep 3, 2019
|
Currently orchagent crashes when there is a table full error, i.e when SAI returns SAI_STATUS_TABLE_FULL. With the error-handling, are you planning to change this behavior when the number of routes exceed the HW limits? |
|
Hi, |
dev-aviz
approved these changes
Sep 26, 2019
sudhanshukumar22
added a commit
to sudhanshukumar22/sonic-swss
that referenced
this pull request
Oct 18, 2019
The routes will be pushed by BGP to Zebra to fpm to be installed in hardware. If fpm returns error, the routes will not be sent by BGP to its peers. Only successful routes are sent by BGP to its peers. The feature can be enabled/disabled in BGP by a CLI. By default, the feature is disabled. Functional specification: sonic-net/SONiC#424 Signed-off by: Preetham Singh <[email protected]> Signed-off by: Sudhanshu Kumar <[email protected]>
sudhanshukumar22
added a commit
to sudhanshukumar22/sonic-utilities
that referenced
this pull request
Oct 18, 2019
Functional specification: sonic-net/SONiC#424 The routes will be pushed by BGP to Zebra to fpm to be installed in hardware. If fpm returns error, the routes will not be sent by BGP to its peers. Only successful routes are sent by BGP to its peers. The feature can be enabled/disabled in BGP by a CLI. By default, the feature is disabled. Functional specification: sonic-net/SONiC#424 Signed-off by: Preetham Singh [email protected] Signed-off by: Sudhanshu Kumar [email protected]
sudhanshukumar22
added a commit
to sudhanshukumar22/sonic-buildimage
that referenced
this pull request
Oct 24, 2019
behavior The routes will be pushed by BGP to Zebra to fpm to be installed in hardware. If fpm returns error, the routes will not be sent by BGP to its peers. Only successful routes are sent by BGP to its peers. The feature can be enabled/disabled in BGP by a CLI. By default, the feature is disabled. Functional specification: sonic-net/SONiC#424 Signed-off by: Preetham Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document gives an overview of how to handle hardware install related errors in BGP. Based on community feedback, I will add an updated document with the following features: