Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR tracker] SONiC ECMP calculator #1163

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

liorghub
Copy link
Contributor

@liorghub liorghub commented Dec 8, 2022

The purpose of ECMP calculator is to calculate which IP interface ECMP will choose and return the physical interface packet will egress from. Packet is defined by a JSON file given as an argument to the tool.
An equal cost multipath (ECMP) is formed when routing table contains multiple next hop addresses for the same destination IP address. ECMP will load balance the outbound traffic between the IP interfaces.

PR title State Status Dependencies Unitest Owner Included in 202211
Add ECMP calculator tool GitHub issue/pull request detail checkers passed sonic-net/sonic-buildimage#12840 tests implemented in sonic-mgmt @liorghub Yes
[Mellanox] Add SDK hash calculator debian and update SDK makefile to compile it GitHub issue/pull request detail checkers passed none N/A @liorghub Yes
Add CLI command for ECMP calculator GitHub issue/pull request detail checkers passed none unittest added @liorghub Yes
[Mellanox] Update ECMP calculator README GitHub issue/pull request detail checkers passed none N/A @liorghub Yes
[Mellanox] [ECMP calculator] Add script usage and more information to script description in help option GitHub issue/pull request detail checkers passed none N/A @liorghub Yes
[Mellanox] [ECMP calculator] Add support for 4600/4600C/2201 platforms with different interface naming method GitHub issue/pull request detail checkers passed none N/A @liorghub Yes

@liat-grozovik
Copy link
Collaborator

all required PRs were merged.
@liorghub please confirm all is in 202211 and if so, we can add it to the RN.

@liorghub
Copy link
Contributor Author

liorghub commented Jan 24, 2023

@liat-grozovik
I have submitted one more PR to enhance the help option (sonic-net/sonic-buildimage#13493).
Once it is in, I will confirm.

@liat-grozovik liat-grozovik changed the title SONiC ECMP calculator PR tracker [PR tracker] SONiC ECMP calculator Feb 6, 2023
@liorghub
Copy link
Contributor Author

all required PRs were merged. @liorghub please confirm all is in 202211 and if so, we can add it to the RN.

@liat-grozovik All required PRs are included in master and 202211.

@liat-grozovik
Copy link
Collaborator

@zhangyanzhao now that the code PRs are merged and all available in 202211 should we close the tracking PR?

@liat-grozovik
Copy link
Collaborator

@zhangyanzhao now that the code PRs are merged and all available in 202211 should we close the tracking PR?

@zhangyanzhao what should be done with the tracking PR now that all the PRs were merged?

@shishao7sxm
Copy link

@liorghub Hi, This is an interesting functionality, i can imagine the operation team will love that. From your perspective, any other scenarios can leverage this capability? SDN?

@zhangyanzhao
Copy link
Collaborator

I am fine to close. Thanks.

@zhangyanzhao
Copy link
Collaborator

It is better to merge it to keep a record. @kannankvs for your awareness, can we add this into the 202211 release notes? Thanks.

@zhangyanzhao zhangyanzhao self-requested a review July 14, 2023 21:50
@zhangyanzhao zhangyanzhao merged commit 3fbe9cc into sonic-net:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants