[dualtor][active-active] Add traffic forwarding section #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolyu
force-pushed
the
aa_dualtor_traffic_forwarding_design
branch
from
1d42070 to
8958c88
Compare
yxieca
reviewed
Dec 2, 2022
doc/dualtor/active_active_hld.md
Outdated
| #### 3.7.1 Special Cases of Traffic Forwarding | ||
|
|
||
| ##### 3.7.1.1 gRPC Traffic to the NiC IP | ||
| There is a scenario that, if ToR A tries to toggle to standby when its peer ToR B is already in standby state, ToR A’s toggle to standby gRPC request will be forwarded to its peer ToR(ToR B) via the tunnel(this is because orchagent re-programs the route before sending standby gRPC request). While ToR B is still in standby, this request will be blackholed. |
There was a problem hiding this comment.
This a conditional scenario: if all IO goes to tunnel routes when mux enters standby state. Please make it clear.
yxieca
reviewed
Dec 2, 2022
lolyu
force-pushed
the
aa_dualtor_traffic_forwarding_design
branch
from
e171dab to
aa50599
Compare
Signed-off-by: Longxiang Lyu <[email protected]>
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
aa_dualtor_traffic_forwarding_design
branch
from
aa50599 to
0d97d96
Compare
yxieca
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 13, 2022
What I did Let mux orch skip adding kernel tunnel routes for SoC IPs. Signed-off-by: Longxiang Lyu [email protected] Why I did it Please refer to sonic-net/SONiC#1132 for more details. How I verified it Add unittest. Signed-off-by: Longxiang Lyu <[email protected]>
yxieca
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 13, 2022
What I did Let mux orch skip adding kernel tunnel routes for SoC IPs. Signed-off-by: Longxiang Lyu [email protected] Why I did it Please refer to sonic-net/SONiC#1132 for more details. How I verified it Add unittest. Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
added a commit
to lolyu/sonic-swss
that referenced
this pull request
Jun 29, 2023
What I did Let mux orch skip adding kernel tunnel routes for SoC IPs. Signed-off-by: Longxiang Lyu [email protected] Why I did it Please refer to sonic-net/SONiC#1132 for more details. How I verified it Add unittest. Signed-off-by: Longxiang Lyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add the traffic forwarding section to the active-active dualtor HLD.
Signed-off-by: Longxiang Lyu [email protected]