Dash ENI create/remove tests #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aputriax
commented
Dec 4, 2022
aputriax
commented
- Added ENI verification test plan.
- Added automated ENI tests.
- Moved all common functions to sai_dash_utils.py
- Skipped failing tests on CI.
|
Making a separate file for common functions for ease of review (see only 2 files). |
saidasheni.py: - test module with ENI creation/deletion and scale verification sai_dash_utils.py: - added classes for storing test configuration - added mixin class with traffic verification methods - fixed VnetAPI issues saidashvnet.py: - moved VnetObjects and VnetAPI to a separate file sai_dash_utils.py Signed-off-by: Yuriy Harhas <[email protected]>
Signed-off-by: Anton Putria <[email protected]>
aputriax
force-pushed
the
dash-eni-tests-upstream
branch
from
f0dd406 to
881cb0a
Compare
Done. Common functions are already merged in PR #298. So this PR now contains only 2 files. |
added 2 commits
December 16, 2022 12:33
Signed-off-by: Yuriy Harhas <[email protected]>
Signed-off-by: Yuriy Harhas <[email protected]>
prsunny
approved these changes
Jan 6, 2023
|
lgtm, we can add more cases on top of this as future commits |
|
@theasianpianist for viz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.