feat(secondary-directory): Support for secondary directory to get hel… #16
Conversation
…m repo 1. Support for such a repo and is compatible with the previous https://burdenbear.github.io/kube-charts-mirror/
1. format project style
| } | ||
| //remove leading "/" to avoid URI missing, by ref: https://github.com/helm/helm/issues/3878 | ||
| //fix https://github.com/sonatype-nexus-community/nexus-repository-helm/issues/14 | ||
| fileName = fileName.startsWith("/") ? fileName.substring(fileName.lastIndexOf("/") + 1) : fileName; |
There was a problem hiding this comment.
Ok! Now I understand the change you are making.
This assumes that you setup a repo that is like:
http://host.name/path/
That path has an index.yaml underneath it, and then also the charts, and the charts are being referenced via:
http://host.name/path/chart.tgz
This change will make that work for sure, and should work fine for others where the all the files are at the root, however if someone does:
http://host.name/index.yaml
http://host.name/charts/charts.tgz
It will fail in this case. I'm not knowledgeable enough to know if anyone has done that yet, but we should think about it. Any thoughts?
There was a problem hiding this comment.
If this is the case, I think I can add a path to the original characters in the metadata. At the time of the proxy, get the original address
There was a problem hiding this comment.
In fact, what you say is similar to another issue I mentioned.
#8
There was a problem hiding this comment.
Where the second options can be satisfied, I think that's another problem.
|
When these features can be merged ? |
|
now |
https://burdenbear.github.io/kube-charts-mirror/
It relates to the following issue #s: