Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock basic method of the QueryBuilder #327

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jun 27, 2021

Subject

I am targeting this branch, because BC.

Changelog

### Fixed
- `EntityManagerMockFactoryTrait` now mocks all the basics methods of the QueryBuilder

@VincentLanglet VincentLanglet requested a review from a team June 27, 2021 17:38
@@ -37,11 +37,27 @@ final protected function createEntityManagerMock(\Closure $qbCallback, array $fi

$qb = $this->createMock(QueryBuilder::class);

$qb->method('select')->willReturn($qb);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use alphabetical sort.

@phansys phansys requested a review from a team June 30, 2021 08:02
@VincentLanglet VincentLanglet merged commit 61fcca5 into sonata-project:1.x Jul 18, 2021
@VincentLanglet VincentLanglet deleted the improveMock branch July 18, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants