Add conflict with doctrine/mongodb-odm <2.0 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are dropping support for doctrine/mongodb-odm 2.0, this allows us to not install alcaeus/mongo-php-adapter in GA for tests
6 tasks
jordisala1991
previously approved these changes
Sep 22, 2020
phansys
previously approved these changes
Sep 22, 2020
core23
previously approved these changes
Sep 22, 2020
core23
reviewed
Sep 22, 2020
| @@ -25,10 +25,13 @@ | |||
| "doctrine/dbal": "^2.6", | |||
| "doctrine/persistence": "^1.3.6 || ^2.0" | |||
| }, | |||
| "conflict": { | |||
| "doctrine/mongodb-odm": "<2.0" | |||
| }, | |||
| "require-dev": { | |||
| "doctrine/common": "^2.7 || ^3.0", | |||
| "doctrine/doctrine-bundle": "^2.0", | |||
There was a problem hiding this comment.
Can you please add a conflict entry for the other doctrine deps too?
They are required as dev dependencies. This gives more control over which versions are installed.
franmomu
dismissed stale reviews from core23, phansys, and jordisala1991
via
8d72324
OskarStark
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Ref: sonata-project/dev-kit#1069
We are dropping support for doctrine/mongodb-odm <2.0, this allows us to not install
alcaeus/mongo-php-adapterin GA for tests.I am targeting this branch, because these changes are BC.
Changelog