Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Sonata\Doctrine\Bridge\Symfony\Bundle\SonataDoctrineBundle #205

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Deprecate Sonata\Doctrine\Bridge\Symfony\Bundle\SonataDoctrineBundle #205

merged 1 commit into from
Jul 4, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented Jul 1, 2020 •
edited
Loading

Subject

Deprecated Sonata\Doctrine\Bridge\Symfony\Bundle\SonataDoctrineBundle.

I am targeting this branch, because this change respects BC.

Triggered by sonata-project/SonataAdminBundle#6173.

Changelog

### Added
- Added `Sonata\Doctrine\Bridge\Symfony\SonataDoctrineBundle`.

### Deprecated
- Deprecated `Sonata\Doctrine\Bridge\Symfony\Bundle\SonataDoctrineBundle` in favor of `Sonata\Doctrine\Bridge\Symfony\SonataDoctrineBundle`.

@phansys phansys added the minor label Jul 1, 2020
@phansys phansys requested a review from a team July 1, 2020 23:13
@phansys phansys mentioned this pull request Jul 1, 2020
Closed
VincentLanglet
VincentLanglet previously approved these changes Jul 2, 2020
View reviewed changes
@phansys phansys changed the title Set "extra.symfony.bundles" property at composer.json in order to be compatible with Symfony Flex Deprecate Sonata\Doctrine\Bridge\Symfony\Bundle\SonataDoctrineBundle Jul 2, 2020
@phansys
Copy link
Member Author

phansys commented Jul 2, 2020

Since the change related to Flex is not working, I removed it in order to just leave the deprecation for Sonata\Doctrine\Bridge\Symfony\Bundle\SonataDoctrineBundle.

VincentLanglet
VincentLanglet previously approved these changes Jul 2, 2020
View reviewed changes
franmomu
franmomu requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@franmomu franmomu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the Sonata\Doctrine\Bridge\Symfony\SonataDoctrineBundle file missing? Maybe also adding an upgrade note?

@phansys
Copy link
Member Author

phansys commented Jul 2, 2020

is the Sonata\Doctrine\Bridge\Symfony\SonataDoctrineBundle file missing?

Yes, I just added the missing file. Thank you!

Maybe also adding an upgrade note?

The upgrade note was already added.

franmomu
franmomu requested changes Jul 2, 2020
View reviewed changes
src/Bridge/Symfony/SonataDoctrineBundle.php Outdated
Comment on lines 30 to 33
public function getPath()
{
return __DIR__.'/..';
}
Copy link
Member

@franmomu franmomu Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since config files are now in the same directory, I guess this is not needed or at least it should be changed to just __DIR__.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're totally right. Removed.

core23
core23 previously approved these changes Jul 2, 2020
View reviewed changes
franmomu
franmomu previously approved these changes Jul 3, 2020
View reviewed changes
jordisala1991
jordisala1991 reviewed Jul 3, 2020
View reviewed changes
src/Bridge/Symfony/SonataDoctrineBundle.php Outdated

protected function getContainerExtensionClass()
{
return SonataDoctrineExtension::class;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed, Symfony cant get this class name right? maybe it was because the old structure and now it works, can you try?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working. Thanks.

@phansys phansys dismissed stale reviews from franmomu and core23 via 905054b July 3, 2020 22:29
@jordisala1991 jordisala1991 merged commit 10dad85 into sonata-project:1.x Jul 4, 2020
@jordisala1991
Copy link
Member

Thank you @phansys

@phansys phansys deleted the flex branch July 4, 2020 12:07
@VincentLanglet
Copy link
Member

@phansys Should we do the same with https://github.com/sonata-project/exporter/blob/2.x/src/Bridge/Symfony/Bundle/SonataExporterBundle.php ?

@phansys
Copy link
Member Author

phansys commented Jul 22, 2020

@phansys Should we do the same with https://github.com/sonata-project/exporter/blob/2.x/src/Bridge/Symfony/Bundle/SonataExporterBundle.php ?

Yes, I guess. I'll do the change today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@core23 core23 core23 left review comments

@franmomu franmomu franmomu left review comments

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phansys @jordisala1991 @VincentLanglet @franmomu @core23