This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 130
Add phpstan and psalm #779
Merged
VincentLanglet
merged 6 commits into
sonata-project:3.x
from
wbloszyk:add_phpstan_and_psalm
Sep 25, 2021
Merged
Add phpstan and psalm #779
VincentLanglet
merged 6 commits into
sonata-project:3.x
from
wbloszyk:add_phpstan_and_psalm
Sep 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a567f1
to
463039d
Compare
Signed-off-by: Wojciech Błoszyk <[email protected]>
463039d
to
1d7607b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A PR is needed on dev-kit
I know. A coffee break. https://github.com/sonata-project/dev-kit/pull/1694/files |
VincentLanglet
suggested changes
Sep 21, 2021
Signed-off-by: Wojciech Błoszyk <[email protected]>
VincentLanglet
previously approved these changes
Sep 22, 2021
wbloszyk
commented
Sep 23, 2021
VincentLanglet
previously approved these changes
Sep 23, 2021
core23
reviewed
Sep 25, 2021
core23
suggested changes
Sep 25, 2021
Signed-off-by: Wojciech Błoszyk <[email protected]>
VincentLanglet
approved these changes
Sep 25, 2021
core23
approved these changes
Sep 25, 2021
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this change respect BC.