Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Deprecate ReST API #2118

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Sep 15, 2021

Subject

I am targeting this branch, because this is BC.

Changelog

### Deprecated
- Deprecated ReST API with FOSRest, Nelmio Api Docs and JMS Serializer.

@VincentLanglet VincentLanglet changed the title Deprecate Api [RFC] Deprecate Api Sep 15, 2021
@jordisala1991
Copy link
Member Author

jordisala1991 commented Sep 15, 2021

With this deprecation there are many things that are solved.

  1. We stop offering an API that becomes outdated very quickly since each version of Nelmio changes completely the annotations
  2. We can remove a lot of dependencies: fosRest, nelmio, JMS serializer. In fact, on master with this PR we would become only dependants on symfony, our own bundles, gauffrete (only php dependency) and imagine (only php dependency) for the require part.
  3. We don't have to worry about Datagrid-bundle anymore because on 4.0 it won't be needed.

I think we should take this PR as the way to go for the rest of bundles and apply the same. wdyt @sonata-project/contributors ?

Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the title and the changelog must also reflect that we are talking specifically about the ReST API.

UPGRADE-3.x.md Outdated Show resolved Hide resolved
UPGRADE-3.x.md Outdated Show resolved Hide resolved
@jordisala1991 jordisala1991 changed the title [RFC] Deprecate Api [RFC] Deprecate Rest API Sep 16, 2021
@jordisala1991 jordisala1991 changed the title [RFC] Deprecate Rest API [RFC] Deprecate ReST API Sep 16, 2021
@jordisala1991 jordisala1991 requested review from phansys and a team September 16, 2021 13:02
phansys
phansys previously approved these changes Sep 16, 2021
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does someone in the @sonata-project/contributors is using the Rest Api ?

src/Extra/ApiMediaFile.php Outdated Show resolved Hide resolved
@wbloszyk wbloszyk requested a review from a team September 17, 2021 06:51
@jordisala1991 jordisala1991 merged commit e985c2c into sonata-project:3.x Sep 17, 2021
@jordisala1991
Copy link
Member Author

3 approvals + @phansys did an approval before. Lets do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants