Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using pager if not needed #2041

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Avoid using pager if not needed #2041

merged 3 commits into from
Aug 14, 2021

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this breaks BC.

VincentLanglet
VincentLanglet previously approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@VincentLanglet VincentLanglet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a phpstan error and test need to be updated

VincentLanglet
VincentLanglet previously approved these changes Aug 14, 2021
View reviewed changes
@jordisala1991 jordisala1991 merged commit 3b9c8da into sonata-project:master Aug 14, 2021
@jordisala1991 jordisala1991 deleted the improvement/avoid-using-get-pager branch August 14, 2021 16:21
@VincentLanglet VincentLanglet mentioned this pull request Aug 15, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordisala1991 @VincentLanglet