Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception message at ModelManager::batchDelete() #813

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Improve exception message at ModelManager::batchDelete() #813

merged 1 commit into from
Apr 5, 2023

Conversation

phansys
Copy link
Member

@phansys phansys commented Apr 3, 2023

Subject

I am targeting this branch, because this change respects BC.

Related to #811 (comment).
Follows sonata-project/SonataDoctrineORMAdminBundle#1734.

Changelog

### Changed
- Exception message at `ModelManager::batchDelete()` in order to provide more details about the failed batch operation

@phansys phansys force-pushed the batch_delete branch 5 times, most recently from 431c4a2 to c49ccfe Compare April 4, 2023 19:53
@phansys phansys marked this pull request as ready for review April 4, 2023 20:06
@phansys phansys added the minor label Apr 4, 2023
@VincentLanglet VincentLanglet merged commit 4600314 into sonata-project:4.x Apr 5, 2023
@VincentLanglet
Copy link
Member

Thanks

@phansys phansys deleted the batch_delete branch April 5, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@franmomu franmomu Awaiting requested review from franmomu

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @VincentLanglet @jordisala1991