Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecations to some ModelManager methods #558

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Add deprecations to some ModelManager methods #558

merged 2 commits into from
Mar 30, 2021

Conversation

franmomu
Copy link
Member

Subject

ModelManagerInterface::getModelInstance is deprecated in sonata-project/admin-bundle.

I am targeting this branch, because these changes are BC.

Changelog

### Deprecated
- Deprecated `ModelManager::getModelInstance()` method.
- Deprecated not passing an instance of `ProxyQueryInterface` to `ModelManager::addIdentifiersToQuery()` method.
- Deprecated not passing an instance of `ProxyQueryInterface` to `ModelManager::batchDelete()` method.

@franmomu franmomu added the minor label Mar 30, 2021
VincentLanglet
VincentLanglet previously approved these changes Mar 30, 2021
View reviewed changes
phansys
phansys previously approved these changes Mar 30, 2021
View reviewed changes
src/Model/ModelManager.php Outdated Show resolved Hide resolved
src/Model/ModelManager.php Outdated Show resolved Hide resolved
@franmomu
Deprecate not passing an instance of ProxyQueryInterface
d9c282a
@franmomu
Deprecate ModelManager::getModelInstance method
49a12dd 
This method is an implementation of ModelManagerInterface::getModelInstance
which has been deprecated.
@franmomu franmomu dismissed stale reviews from phansys and VincentLanglet via 49a12dd March 30, 2021 16:30
@phansys phansys requested review from VincentLanglet and a team March 30, 2021 16:46
@VincentLanglet VincentLanglet merged commit 97c3239 into sonata-project:3.x Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franmomu @phansys @VincentLanglet