Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Pager::getResults in favor of getCurrentPageResults #509

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Deprecate Pager::getResults in favor of getCurrentPageResults #509

merged 3 commits into from
Jan 19, 2021

Conversation

franmomu
Copy link
Member

Subject

This PR deprecates Pager::getResults in favor of getCurrentPageResults. It also avoids triggering some deprecations in ModelManager.

I am targeting this branch, because this is BC.

Changelog

### Added
- Added implementation of `Pager::getCurrentPageResults()` method.
### Deprecated
- Deprecated `Pager::getResults()` method in favor of `Pager::getCurrentPageResults()`.

@franmomu franmomu added the minor label Jan 18, 2021
VincentLanglet
VincentLanglet previously approved these changes Jan 18, 2021
View reviewed changes
VincentLanglet
VincentLanglet previously approved these changes Jan 18, 2021
View reviewed changes
@VincentLanglet VincentLanglet requested a review from a team January 19, 2021 12:12
phansys
phansys previously approved these changes Jan 19, 2021
View reviewed changes
src/Datagrid/Pager.php Outdated Show resolved Hide resolved
@franmomu franmomu dismissed stale reviews from phansys and VincentLanglet via 3ad91e7 January 19, 2021 16:41
phansys
phansys previously approved these changes Jan 19, 2021
View reviewed changes
VincentLanglet
VincentLanglet previously approved these changes Jan 19, 2021
View reviewed changes
@franmomu franmomu dismissed stale reviews from VincentLanglet and phansys via f3f3ba9 January 19, 2021 21:51
@VincentLanglet VincentLanglet merged commit d4617b4 into sonata-project:3.x Jan 19, 2021
@VincentLanglet
Copy link
Member

Thanks @franmomu

@franmomu franmomu deleted the fixes branch January 19, 2021 22:00
@SonataCI
Copy link
Collaborator

Ok @franmomu,

I requested a new release for SonataDoctrineMongoDBAdminBundle via Slack in #releases channel 👍

If you want to get notified about new releases, make sure to follow SonataNews on Twitter!

@sonata-project sonata-project deleted a comment from franmomu Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@phansys phansys phansys left review comments

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franmomu @VincentLanglet @SonataCI @phansys