handle SonataAdminBundle Pager::nbresults deprecation #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
nbresults_deprecation
branch
from
bc850f9
to
2ede82e
Compare
OskarStark
previously approved these changes
Jan 10, 2021
franmomu
reviewed
Jan 10, 2021
franmomu
approved these changes
Jan 10, 2021
VincentLanglet
approved these changes
Jan 10, 2021
|
Thanks |
franmomu
added a commit
to franmomu/SonataDoctrineMongoDBAdminBundle
that referenced
this pull request
Jan 10, 2021
It was missing from sonata-project#501
VincentLanglet
pushed a commit
that referenced
this pull request
Jan 10, 2021
It was missing from #501
VincentLanglet
pushed a commit
that referenced
this pull request
Jan 16, 2021
* handle SonataAdminBundle Pager::nbresults deprecation (#501) * handle SonataAdminBundle Pager::nbresults deprecation * make setResultsCount() private * Remove suggested package The user should have ext-mongodb installed. * Avoid triggering deprecations These methods were deprecated in sonata-project/admin-bundle. * Add upgrade note It was missing from #501 * DevKit updates (#505) * fix compatibility * fix compatibility * cs-fixer * remove redundant cast to int Co-authored-by: David Maicher <[email protected]> Co-authored-by: Fran Moreno <[email protected]> Co-authored-by: Sonata CI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because its BC.
See
sonata-project/SonataAdminBundle#6732
sonata-project/SonataDoctrineORMAdminBundle#1257
Changelog