Remove deprecations constructing FieldDescription #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
previously approved these changes
Nov 5, 2020
| @@ -125,7 +125,7 @@ public function getNewFieldDescriptionInstance($class, $name, array $options = [ | |||
|
|
|||
| [$metadata, $propertyName, $parentAssociationMappings] = $this->getParentMetadataForProperty($class, $name); | |||
|
|
|||
| $fieldDescription = new FieldDescription(); | |||
| $fieldDescription = new FieldDescription($name, $options); | |||
| $fieldDescription->setName($name); | |||
There was a problem hiding this comment.
You can remove this line and the next one
In sonata-project/admin-bundle 3.78 a deprecation was added to force to construct FieldDescription with "name" and "options".
franmomu
force-pushed
the
deprecations_field_description
branch
from
6846911
to
6897912
Compare
VincentLanglet
approved these changes
Nov 5, 2020
|
Thanks @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
In sonata-project/admin-bundle 3.78 a deprecation was added to force to construct FieldDescription with
nameandoptions.I am targeting this branch, because these changes are BC.
Changelog