Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some deprecations about invalid values #451

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

franmomu
Copy link
Member

Subject

Add some deprecations at ModelManager in order to be prepared for the next major.

It's based on sonata-project/SonataDoctrineORMAdminBundle#1049

This would make PHPStan check pass in #450

I am targeting this branch, because these changes are BC.

Changelog

### Deprecated
- Deprecated passing `null` as argument 2 for `ModelManager::find()`;
- Deprecated passing `null` as argument 1 for `ModelManager::getNormalizedIdentifier()`;
- Deprecated passing other type than `object` as argument 1 for `ModelManager::getUrlSafeIdentifier()`;

@franmomu franmomu added the minor label Oct 29, 2020
VincentLanglet
VincentLanglet previously approved these changes Oct 29, 2020
@VincentLanglet VincentLanglet requested a review from a team October 29, 2020 11:45
@phansys phansys merged commit 716d6fa into sonata-project:3.x Oct 29, 2020
@phansys
Copy link
Member

phansys commented Oct 29, 2020

Thank you @franmomu!

@franmomu franmomu deleted the deprecation_invalid_values branch October 29, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants