Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate getParentFieldDescription #384

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Deprecate getParentFieldDescription #384

merged 1 commit into from
Jul 31, 2020

Conversation

franmomu
Copy link
Member

Subject

Ref: sonata-project/SonataAdminBundle#6234 and sonata-project/SonataDoctrineORMAdminBundle#1082

This method is not used.

I am targeting this branch, because this is BC.

Changelog

### Deprecated
- Deprecate `ModelManager::getParentFieldDescription()`.

@franmomu franmomu added the minor label Jul 31, 2020
@franmomu franmomu changed the title Deprecated getParentFieldDescription Deprecate getParentFieldDescription Jul 31, 2020
@jordisala1991 jordisala1991 merged commit 2948c17 into sonata-project:3.x Jul 31, 2020
@jordisala1991
Copy link
Member

Thank you @franmomu

@franmomu franmomu deleted the deprecate_method branch July 31, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @jordisala1991