Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce showInDashboard instead of showIn #7658

Merged
merged 1 commit into from
Dec 25, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Dec 16, 2021

Subject

Closes #7642.

Changelog

### Added
- `AdminInterface::showInDashboard()` method.

### Deprecated
- `AdminInterface::showIn()` method.

@VincentLanglet VincentLanglet force-pushed the showInDashboard branch 5 times, most recently from 807114c to 3489789 Compare December 16, 2021 22:41
@VincentLanglet VincentLanglet marked this pull request as ready for review December 16, 2021 23:13
@VincentLanglet VincentLanglet requested a review from a team December 16, 2021 23:13
@soullivaneuh
Copy link
Member

I am unsure about the final naming, however this looks to fix the issue.

However, be aware that the issue is reported on the 3.x release. Can this be easily back ported?

@VincentLanglet
Copy link
Member Author

I am unsure about the final naming

I'm open to suggestion.
The call showIn was made on the Context_Dashboard constant so showInDashboard seems natural to me.
But I didn't look where it's use so maybe another name is better.

However, be aware that the issue is reported on the 3.x release. Can this be easily back ported?

In 3.x, it's "only" a deprecation, which could be ignored.
Not sure it worth back porting this (and dealing with conflict).
When bumping to 3.x to 4.x, you'll just have to rename showIn to showInDashboard.

jordisala1991
jordisala1991 previously approved these changes Dec 18, 2021
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@VincentLanglet VincentLanglet merged commit 6ea9cf5 into sonata-project:4.x Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresolvable showIn deprecation case
6 participants