Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelList btn_delete bug when hit Enter key #8106

Closed
tdumalin opened this issue Sep 21, 2023 · 2 comments
Closed

ModelList btn_delete bug when hit Enter key #8106

tdumalin opened this issue Sep 21, 2023 · 2 comments

Comments

@tdumalin
Copy link
Contributor

Environment

Sonata packages

show

$ composer show --latest 'sonata-project/*'
# Put the result here.
Info from https://repo.packagist.org: #StandWithUkraine
Color legend:
- patch or minor release available - update recommended
- major release available - update possible
- up to date version

Direct dependencies required in composer.json:
sonata-project/admin-bundle              4.25.0 4.27.0 The missing Symfony Admin Generator
sonata-project/doctrine-orm-admin-bundle 4.9.1  4.13.0 Integrate Doctrine ORM into the SonataAdminBundle

Transitive dependencies not required in composer.json:
sonata-project/block-bundle              4.21.0 5.0.1  Symfony SonataBlockBundle
sonata-project/cache                     2.2.0  2.2.0  Cache library
Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested.
sonata-project/doctrine-extensions       2.1.0  2.3.0  Doctrine2 behavioral extensions
sonata-project/exporter                  3.1.1  3.2.0  Lightweight Exporter library
sonata-project/form-extensions           1.18.1 2.0.0  Symfony form extensions
sonata-project/twig-extensions           2.1.0  2.3.0  Sonata twig extensions

Symfony packages

show

$ composer show --latest 'symfony/*'
# Put the result here.
Color legend:
- patch or minor release available - update recommended
- major release available - update possible
- up to date version

Direct dependencies required in composer.json:
symfony/config                     v5.4.21 v6.3.2  Helps you find, load, combine, autofill and validate configuration values of any kind
symfony/console                    v5.4.24 v6.3.4  Eases the creation of beautiful and testable command line interfaces
symfony/debug-bundle               v5.4.21 v6.3.2  Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge in...
symfony/dotenv                     v5.4.22 v6.3.0  Registers environment variables from a .env file
symfony/finder                     v5.4.21 v6.3.3  Finds files and directories via an intuitive fluent interface
symfony/flex                       v1.20.0 v2.3.3  Composer plugin for Symfony
symfony/framework-bundle           v5.4.24 v6.3.4  Provides a tight integration between Symfony components and the Symfony full-stack framework
symfony/intl                       v5.4.23 v6.3.2  Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library
symfony/mailer                     v5.4.22 v6.3.0  Helps sending emails
symfony/maker-bundle               v1.49.0 v1.51.1 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget abo...
symfony/runtime                    v5.4.22 v6.3.2  Enables decoupling PHP applications from global state
symfony/stopwatch                  v5.4.21 v6.3.0  Provides a way to profile code
symfony/translation                v5.4.24 v6.3.3  Provides tools to internationalize your application
symfony/ux-autocomplete            v2.9.1  v2.11.2 JavaScript Autocomplete functionality for Symfony
symfony/ux-live-component          v2.9.1  v2.11.2 Live components for Symfony
symfony/ux-twig-component          v2.9.1  v2.11.2 Twig components for Symfony
symfony/web-profiler-bundle        v5.4.24 v6.3.2  Provides a development tool that gives detailed information about the execution of any request
symfony/webpack-encore-bundle      v1.17.1 v2.0.1  Integration with your Symfony app & Webpack Encore!
symfony/yaml                       v5.4.23 v6.3.3  Loads and dumps YAML files

Transitive dependencies not required in composer.json:
symfony/asset                      v5.4.21 v6.3.0  Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files
symfony/cache                      v5.4.23 v6.3.4  Provides extended PSR-6, PSR-16 (and tags) implementations
symfony/cache-contracts            v2.5.2  v3.3.0  Generic abstractions related to caching
symfony/css-selector               v5.4.21 v6.3.2  Converts CSS selectors to XPath expressions
symfony/dependency-injection       v5.4.24 v6.3.4  Allows you to standardize and centralize the way objects are constructed in your application
symfony/deprecation-contracts      v3.3.0  v3.3.0  A generic function and convention to trigger deprecation notices
symfony/doctrine-bridge            v5.4.24 v6.3.4  Provides integration for Doctrine with various Symfony components
symfony/error-handler              v5.4.24 v6.3.2  Provides tools to manage errors and ease debugging PHP code
symfony/event-dispatcher           v5.4.22 v6.3.2  Provides tools that allow your application components to communicate with each other by dispatching events and...
symfony/event-dispatcher-contracts v3.3.0  v3.3.0  Generic abstractions related to dispatching event
symfony/expression-language        v5.4.21 v6.3.0  Provides an engine that can compile and evaluate expressions
symfony/filesystem                 v5.4.23 v6.3.1  Provides basic utilities for the filesystem
symfony/form                       v5.4.24 v6.3.2  Allows to easily create, process and reuse HTML forms
symfony/http-foundation            v5.4.24 v6.3.4  Defines an object-oriented layer for the HTTP specification
symfony/http-kernel                v5.4.24 v6.3.4  Provides a structured process for converting a Request into a Response
symfony/mime                       v5.4.23 v6.3.3  Allows manipulating MIME messages
symfony/monolog-bridge             v5.4.22 v6.3.1  Provides integration for Monolog with various Symfony components
symfony/monolog-bundle             v3.8.0  v3.8.0  Symfony MonologBundle
symfony/options-resolver           v5.4.21 v6.3.0  Provides an improved replacement for the array_replace PHP function
symfony/password-hasher            v5.4.21 v6.3.0  Provides password hashing utilities
symfony/polyfill-intl-grapheme     v1.27.0 v1.28.0 Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-icu          v1.27.0 v1.28.0 Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn          v1.27.0 v1.28.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-intl-normalizer   v1.27.0 v1.28.0 Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring          v1.27.0 v1.28.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php73             v1.27.0 v1.28.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/polyfill-php80             v1.27.0 v1.28.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions
symfony/polyfill-php81             v1.27.0 v1.28.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions
symfony/process                    v5.4.24 v6.3.4  Executes commands in sub-processes
symfony/property-access            v5.4.22 v6.3.2  Provides functions to read and write from/to an object or array using a simple string notation
symfony/property-info              v5.4.24 v6.3.0  Extracts information about PHP class' properties using metadata of popular sources
symfony/routing                    v5.4.22 v6.3.3  Maps an HTTP request to a set of configuration variables
symfony/security-acl               v3.3.2  v3.3.2  Symfony Security Component - ACL (Access Control List)
symfony/security-bundle            v5.4.22 v6.3.4  Provides a tight integration of the Security component into the Symfony full-stack framework
symfony/security-core              v5.4.22 v6.3.3  Symfony Security Component - Core Library
symfony/security-csrf              v5.4.21 v6.3.2  Symfony Security Component - CSRF Library
symfony/security-guard             v5.4.22 v5.4.27 Symfony Security Component - Guard
symfony/security-http              v5.4.23 v6.3.4  Symfony Security Component - HTTP Integration
symfony/serializer                 v5.4.24 v6.3.4  Handles serializing and deserializing data structures, including object graphs, into array structures or other...
symfony/service-contracts          v2.5.2  v3.3.0  Generic abstractions related to writing services
symfony/string                     v5.4.22 v6.3.2  Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a ...
symfony/translation-contracts      v2.5.2  v3.3.0  Generic abstractions related to translation
symfony/twig-bridge                v5.4.22 v6.3.2  Provides integration for Twig with various Symfony components
symfony/twig-bundle                v5.4.21 v6.3.0  Provides a tight integration of Twig into the Symfony full-stack framework
symfony/validator                  v5.4.24 v6.3.4  Provides tools to validate values
symfony/var-dumper                 v5.4.24 v6.3.4  Provides mechanisms for walking through any arbitrary PHP variable
symfony/var-exporter               v6.3.0  v6.3.4  Allows exporting any serializable PHP data structure to plain PHP code

PHP version

$ php -v
# Put the result here.
PHP 8.2.8 (cli) (built: Aug  9 2023 05:39:34) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.8, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.8, Copyright (c), by Zend Technologies

Subject

On an admin form, if there is one field using ModelList and another text field. If you hit enter when focusing on the text input it trigger the ModelList button because it doesn't have type="button" attribute.

Minimal repository with the bug

Steps to reproduce

Create an admin with a form having two fields, a ModelList and a TextType, focus the text input, hit enter

Expected results

Post the form and do not clear the ModelList value

Actual results

Post the form and clear the ModelList value

@VincentLanglet
Copy link
Member

Hi ! Can you provide a Pr @tdumalin ?

@tdumalin
Copy link
Contributor Author

Hi @VincentLanglet ,
Here you go !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants