-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Download Bar #34
base: master
Are you sure you want to change the base?
Conversation
Re-centered the downloads text, and moved the download progress bar down, while decreasing its height
Could you please provide a before and after picture and a reason for these changes? It would help a lot. |
Oh, I see what you mean. Although I don't disagree that it's a good idea, I don't think any of us (somini, mr. late, and myself) would agree to changing the way the skin looks from the way Pulseh had it in the first place. That being said, there's nothing stopping you from keeping it as your own personal mod since that file doesn't seem like one that gets updated often (last update for the uistatuspanel.layout was 11/11/2014). Edit: On second thought, I don't think that's a very good reason to shoot down your idea, nor is it fair. Give me about a day and I'll think about it. Somini, I would like your opinion on this as well if you have one. Edit2: Actually, I see now why this would not work. First off, the bottom portion of the screen does not really give you enough room to stack the download text on top of the download bar. It just looks a little too squished together, in my opinion, which makes it look a little less organized. Second, the thin black border of the download bar does not surround the blue bar entirely, but instead the bottom border runs off to the left a little too much (this is just a small problem that could probably be fixed easily). |
I think it looks decent enough, if you can fix the issue with it. If you're worried about changing the skin from what Pulseh wanted, you could also add it as a tweak that's disabled by default. PS, you can prefix a username with @ (ie @CaptainMagma), and GitHub will linkify the username, and also tell the user they got mentioned. |
Yeah, I think making this a tweak, or even an Override, is the way to go. |
Re-centered the downloads text, and moved the download progress bar down, while decreasing its height