Remove dependency on the itertools crate
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate was only used in two small places in the ouroboros_macro crate which could be easily replaced with stdlib variants. Removing it might help compile times a bit.
dnaka91
changed the title
intertools crateitertools crate
Ten0
approved these changes
May 23, 2024
|
@someguynamedjosh Do you mind publishing a new release for this? This should reduce our compilation speed by a little bit. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate was only used in two small places in the ouroboros_macro crate which could be easily replaced with stdlib variants.
Removing it might help compile times a bit.
Found this rather randomly as I wondered why itertools shows up in my depedency tree, saw the macro crate uses it and replaced it as I saw the few places where it's used are trivial.