-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to gomarkdown #40
Conversation
@jessp01 In the Let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jessp01
Hi @mandolyte , Yes, that's a relic from when we moved mdtopdf.go into On a more general level, do you reckon perhaps we should move these resource files (russian.md, test.md, helvetica_1251.json, etc) into a separate directory? Cheers, |
@jessp01 Agree... seems to be getting sort of messy in there. And I recall there may be some duplication left in the parent directory. Migration to the gomarkdown is fairly significant, even if invisible to a user. Deserves at least a semver of 1.6. But wondering if a 2.0 might be appropriate. Thoughts? |
@mandolyte , obviously, it's your call:) But I agree it's significant, even if I've gone to some lengths to make sure it's not something end users will notice (to wit: to ensure I haven't broken anything). I don't think going with v2.0.0 is unreasonable. |
Sounds good... will wait until tomorrow... won't have time to release today. Thanks for all the work you have invested!! |
Cheers, @mandolyte. Most happy to collaborate. It's always nice when the maintainer is sensible, responsive and appreciative:) Not always the case, alas. Also, I've submitted #41 which removes additional |
As the BlackFriday project is no longer active, this pull migrates us to gomarkdown