Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to gomarkdown #40

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Conversation

jessp01
Copy link
Collaborator

@jessp01 jessp01 commented Aug 14, 2023

As the BlackFriday project is no longer active, this pull migrates us to gomarkdown

@jessp01 jessp01 changed the title Move to gomarkdown Migrate to gomarkdown Aug 15, 2023
@mandolyte
Copy link
Collaborator

@jessp01 In the cmd/md2pdf folder I ran go run md2pdf -i test.md -o test.pdf and found that the md file doesn't have valid references to the image files. They are '../images/xxx' and need another level now that these files are another level deep in the folder structure. Otherwise, looks good! I can make this change after I merge if you wish.

Let me know

Copy link
Collaborator

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jessp01

@mandolyte mandolyte merged commit 99e9f05 into solworktech:master Aug 16, 2023
@jessp01
Copy link
Collaborator Author

jessp01 commented Aug 16, 2023

Hi @mandolyte ,

Yes, that's a relic from when we moved mdtopdf.go into cmd/md2pdf, it's not related to the migration to gomarkdown of course but I fixed it just now.

On a more general level, do you reckon perhaps we should move these resource files (russian.md, test.md, helvetica_1251.json, etc) into a separate directory?

Cheers,

@mandolyte
Copy link
Collaborator

@jessp01 Agree... seems to be getting sort of messy in there. And I recall there may be some duplication left in the parent directory.

Migration to the gomarkdown is fairly significant, even if invisible to a user. Deserves at least a semver of 1.6. But wondering if a 2.0 might be appropriate. Thoughts?

@jessp01
Copy link
Collaborator Author

jessp01 commented Aug 16, 2023

@mandolyte , obviously, it's your call:) But I agree it's significant, even if I've gone to some lengths to make sure it's not something end users will notice (to wit: to ensure I haven't broken anything). I don't think going with v2.0.0 is unreasonable.

@mandolyte
Copy link
Collaborator

Sounds good... will wait until tomorrow... won't have time to release today. Thanks for all the work you have invested!!

@jessp01
Copy link
Collaborator Author

jessp01 commented Aug 16, 2023

Cheers, @mandolyte. Most happy to collaborate. It's always nice when the maintainer is sensible, responsive and appreciative:) Not always the case, alas.

Also, I've submitted #41 which removes additional BlackFriday references from the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants