interesting: fix defaulting of dc integration test and conversion for triggers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfojtik
commented
Nov 13, 2017
| @@ -75,7 +75,9 @@ func setEssentialDefaults(dc *deployapi.DeploymentConfig) *deployapi.DeploymentC | |||
| MaxSurge: intstr.FromString("25%"), | |||
| } | |||
| dc.Spec.Strategy.ActiveDeadlineSeconds = int64ptr(21600) | |||
| dc.Spec.Triggers = []deployapi.DeploymentTriggerPolicy{} | |||
| dc.Spec.Triggers = []deployapi.DeploymentTriggerPolicy{ | |||
| {Type: deployapi.DeploymentTriggerOnConfigChange}, | |||
mfojtik
force-pushed
the
rebase_1.8.1-mfojtik-dc-int
branch
from
6bc1219 to
70b3d34
Compare
|
@soltysh fixed dc integration |
1 similar comment
|
@soltysh fixed dc integration |
soltysh
pushed a commit
that referenced
this pull request
Feb 12, 2018
Automatic merge from submit-queue. CLI: add support for deployments in oc status @smarterclayton this is a long overdue... current state: ``` $ oc status In project My Project (myproject) on server https://127.0.0.1:8443 svc/ruby-deploy - 172.30.174.234:8080 deployment/ruby-deploy deploys istag/ruby-deploy:latest <- bc/ruby-deploy source builds https://github.com/openshift/ruby-ex.git on istag/ruby-22-centos7:latest build #1 failed 5 hours ago - bbb6701: Merge pull request #18 from durandom/master (Ben Parees <[email protected]>) deployment #2 running for 4 hours - 0/1 pods (warning: 53 restarts) deployment #1 deployed 5 hours ago ``` TODO: - [x] Add rollouts similar to deployment configs - [x] Fix unit tests / Add unit tests - [x] Deal with HPA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.