fix(SFT-1649): purging old submission assets when empty string passed in

solspace · Dec 11, 2024 · 7c07203 · 7c07203
1 parent ee89d7f
commit 7c07203
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/...es/plugin/src/Bundles/Fields/Implementations/FileUpload/FileRemovalOnSubmissionDelete.php b/...es/plugin/src/Bundles/Fields/Implementations/FileUpload/FileRemovalOnSubmissionDelete.php
@@ -29,7 +29,9 @@ public function removeSubmissionFiles(Event $event): void
 
             if (\is_array($value)) {
                 foreach ($value as $id) {
-                    \Craft::$app->elements->deleteElementById($id);
+                    if (\is_int($id)) {
+                        \Craft::$app->elements->deleteElementById($id);
+                    }
                 }
             }
         }

diff --git a/packages/plugin/src/Services/SubmissionsService.php b/packages/plugin/src/Services/SubmissionsService.php
@@ -408,11 +408,13 @@ public function purgeSubmissions(?int $age = null): array
 
             $assetIds = array_unique($assetIds);
             foreach ($assetIds as $assetId) {
-                \Craft::$app->elements->deleteElementById(
-                    $assetId,
-                    hardDelete: true,
-                );
-                ++$deletedAssets;
+                if (\is_int($assetId)) {
+                    \Craft::$app->elements->deleteElementById(
+                        $assetId,
+                        hardDelete: true,
+                    );
+                    ++$deletedAssets;
+                }
             }
         }