initial TLSRoute support #10601
Open
initial TLSRoute support #10601
+1,616
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kick-ci |
puertomontt
commented
Feb 13, 2025
| @@ -248,6 +248,16 @@ func (p *plugin) computeTcpFilterChain( | |||
| }, nil | |||
| } | |||
|
|
|||
| // needed to handle passthrough | |||
| if sslConfig.GetSslSecrets() == nil && len(sslConfig.GetSniDomains()) != 0 { | |||
There was a problem hiding this comment.
in the case of passthrough, we don't have ssl secrets, only sni domain.
puertomontt
commented
Feb 13, 2025
| @@ -67,6 +67,14 @@ func includeTlsInspectorForAggregateListener(in *v1.AggregateListener) bool { | |||
| } | |||
| } | |||
|
|
|||
| for _, tcpListener := range in.GetTcpListeners() { | |||
There was a problem hiding this comment.
for the case of TLS Passthrough over TCP (which is the usecase for TLSRoutes), we need to add the tls inspector
|
Visit the preview URL for this PR (updated for commit 4594c2c): https://gloo-edge--pr10601-puertomontt-tls-rout-e8bxf1cb.web.app (expires Thu, 20 Feb 2025 15:49:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds initial support for TLSRoutes. TLSRoutes are similar to TCPRoutes, but the distinction between them is that TLSRoutes allows routing decisions by SNI. See docs.
This PR adds support for TLS Passthrough on a TLS listener using a TLSRoute.
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
This PR doesn't add TLS support for TCPRoutes (kgateway-dev#10621)
Checklist: