Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows per test directory for generated files on failure #10579

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

andy-fong
Copy link

@andy-fong andy-fong commented Jan 21, 2025

Description

For some test suites (eg. AI Extension TestSuite), the envoy proxy pod will spin up and get shut down on each individual test, so it would be a lot easier to troubleshoot flakes if the log dumps to a per test directory.

Not sure which tests would need this, so I am making this an optional parameter to minimize changes. I can update all tests to dump into per test directory if desired.

This solo-projects PR depends on this PR.

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7634

@@ -0,0 +1,6 @@
changelog:
- type: NON_USER_FACING
issueLink: https://github.com/solo-io/solo-projects/issues/7634
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is a solo-project issue but gloo is essentially private now.... is this ok?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its been done

Copy link

github-actions bot commented Jan 21, 2025

Visit the preview URL for this PR (updated for commit 9132ed0):

https://gloo-edge--pr10579-andyfong-per-test-lo-0matj2q5.web.app

(expires Tue, 28 Jan 2025 21:25:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@andy-fong andy-fong changed the title Allows per test directory For generated files on failure Allows per test directory for generated files on failure Jan 21, 2025
@ryanrolds
Copy link

Can you provide a link an example of the artifacts this is creating?

@andy-fong
Copy link
Author

Can you provide a link an example of the artifacts this is creating?

I faked a failure here: https://github.com/solo-io/solo-projects/actions/runs/12912252477/job/36008229575
The direct download link of the artifact is here: https://github.com/solo-io/solo-projects/actions/runs/12912252477/artifacts/2469386102

@soloio-bulldozer soloio-bulldozer bot merged commit 91ba1c5 into main Jan 22, 2025
22 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the andyfong-per-test-logs-for-failed-test branch January 22, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants