gateway2/delegation: fix cycle detection #10405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug in how cycles are detected when evaluating a delegation chain, because of which a multi-level delegation tree with the same child route being referenced by multiple parent HTTP routes is broken. This change fixes the detection of cycles during the evaluation of the delegation chain. --- Testing done: Added a new translator unit test which fails without the fix. Signed-off-by: Shashank Ram <[email protected]>
|
Issues linked to changelog: |
|
Visit the preview URL for this PR (updated for commit 33567f6): https://gloo-edge--pr10405-shashankram-fix-1037-khm7s19y.web.app (expires Tue, 03 Dec 2024 15:49:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
sam-heilbron
approved these changes
Nov 26, 2024
|
/kick |
|
/kick-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in how cycles are detected when evaluating a delegation chain, because of which a multi-level delegation tree with the same child route being referenced by multiple parent HTTP routes is broken. This change fixes the detection of cycles during the evaluation of the delegation chain.
Refer to k8sgateway#10379 for more details on how to reproduce this.
Testing done:
Added a new translator unit test which fails without the fix.