Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SolidusSupport.solidus_gem_version #37

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Deprecate SolidusSupport.solidus_gem_version #37

merged 1 commit into from
Feb 18, 2020

Conversation

kennyadsl
Copy link
Member

It does not make a lot of sense nowadays. We have Spree.solidus_gem_version ( 😆) since Solidus 1.2

@kennyadsl kennyadsl requested a review from a team December 18, 2019 17:21
@kennyadsl kennyadsl self-assigned this Dec 18, 2019
tvdeyen
tvdeyen reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to introduce a Solidus.gem_version instead?

@spaghetticode
Copy link
Member

This should be green after merging #36

@kennyadsl kennyadsl force-pushed the deprecate-solidus-gem-version branch from 2b7a09a to 98bf2dd Compare January 14, 2020 13:35
@kennyadsl kennyadsl requested a review from aldesantis February 11, 2020 12:49
@kennyadsl kennyadsl force-pushed the deprecate-solidus-gem-version branch from 98bf2dd to e65847d Compare February 11, 2020 14:24
@kennyadsl
Copy link
Member Author

Would it make sense to introduce a Solidus.gem_version instead?

Spree.gem_version comes from core, I think it will be deprecated in favor of Solidus.gem_version if/when we decide what to do with the namespace.

spaghetticode
spaghetticode approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kennyadsl

@spaghetticode spaghetticode merged commit d5899f8 into solidusio:master Feb 18, 2020
@spaghetticode spaghetticode deleted the deprecate-solidus-gem-version branch February 18, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen left review comments

@aldesantis aldesantis aldesantis approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennyadsl @spaghetticode @tvdeyen @aldesantis