Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a billing address on the subscription #119

Merged
merged 9 commits into from
Jun 17, 2020

Conversation

aldesantis
Copy link
Member

@aldesantis aldesantis commented Jun 17, 2020

Closes #117.

Adds the ability for users and admins to set the billing address on their subscription:

  • When creating a subscription on the backend, the billing address is set directly on the subscription through the backend UI.
  • When creating a subscription on the storefront or via the API, the billing address is copied from the order, just like what happens for the shipping address.

The subscription processing logic has also been adjusted slightly in order to:

  • group subscription processing jobs by both shipping and billing address, and
  • use either the subscription's billing address or the user's default billing address when processing a subscription.

@aldesantis aldesantis self-assigned this Jun 17, 2020
@aldesantis aldesantis added the enhancement Improves an existing feature. label Jun 17, 2020
@aldesantis aldesantis force-pushed the aldesantis/billing-address branch from 7913638 to e3f2712 Compare June 17, 2020 11:51
@aldesantis aldesantis merged commit 38ef3d0 into master Jun 17, 2020
@aldesantis aldesantis deleted the aldesantis/billing-address branch June 17, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add billing address to subscriptions
1 participant