This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Always use the same zipcode in address factory #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😞 |
|
We'll need a comment explaining why this change needs to be there. Could we also change this in core? |
Senjai
approved these changes
May 8, 2017
tvdeyen
force-pushed
the
harden-credit-card-checkout-spec
branch
from
b3a4198 to
71adeec
Compare
|
@Senjai added a comment.
👍 I also thought this might be a good idea. Will open a PR. |
The Solidus address factory randomizes the zipcode. The OrderWalkThrough we use in the credit card checkout spec uses this factory for the user addresses. For credit card payments we transmit the billing address to braintree, for paypal payments the shipping address. As we match the body in our VCR settings VCR can not match the request anymore and therefore cannot replay existing cassettes. By modifying the spree address factory we ensure that the zipcode is always the same.
tvdeyen
force-pushed
the
harden-credit-card-checkout-spec
branch
from
71adeec to
6ad3a88
Compare
It turns out that we want to have the address factory support zipcodes for various countries. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solidus address factory randomizes the zipcode. The OrderWalkThrough we use in the credit card checkout spec uses this factory for the user addresses.
For credit card payments we transmit the billing address to braintree, for paypal payments the shipping address.
As we match the body in our VCR settings VCR can not match the request anymore and therefore cannot replay existing cassettes. This leads to sporadic failing tests.
By modifying the spree address factory we ensure that the zipcode is always the same.