This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Handle errors when creating customer #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't just assume the create is always successful. If it fails, we should raise the typical GatewayError so that we can properly handle it elsewhere.
It's silly.
It doesn't make sense for the way RSpec is written.
Rubocop demands it. So it shall be.
These specs fail very often on Travis. Temporarily skipping them while we work on making them reliable.
adammathys
force-pushed
the
safe-customer-create
branch
from
7a546c3 to
43938d1
Compare
The most recent version of Solidus has removed `update_totals`. There's no specific reason for this to be calling that instead of simply `update!` which isn't going anywhere anytime soon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't just assume the create is always successful. If it fails, we should raise the typical GatewayError so that we can properly handle it elsewhere.