This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Support tokens without specifying payment_method #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its way more hassle to have to specify a payment method id, which most stores won't want to do.
luukveenis
reviewed
Oct 26, 2016
| where(active: true). | ||
| find(params[:payment_method_id]) | ||
| if params[:payment_method_id] | ||
| @gateway = ::SolidusPaypalBraintree::Gateway.find_by!(id: params[:payment_method_id]) |
There was a problem hiding this comment.
does it matter that this allows payment methods with active: false?
There was a problem hiding this comment.
I don't personally care... I don't think giving people tokens is a risky activity, but open to hearing otherwise
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its way more hassle to have to specify a payment method id, which most
stores won't want to do.