This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Address improvements #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrunsdon
force-pushed
the
address_improvements
branch
4 times, most recently
from
b1fc148 to
bb5eddd
Compare
Lets us keep the logic of translating transaction addresses into solidus addresses in one place
cbrunsdon
force-pushed
the
address_improvements
branch
from
bb5eddd to
0189a0f
Compare
adammathys
previously requested changes
Oct 26, 2016
| address2: ta.address_line_2, | ||
| zipcode: ta.zip, | ||
| phone: transaction.phone | ||
| transaction.address && transaction.address.to_spree_address.try do |address| |
There was a problem hiding this comment.
Why would to_spree_address every return nil? I don't think this try provides anything.
There was a problem hiding this comment.
pretty sure I wanted a .tap there...
cbrunsdon
force-pushed
the
address_improvements
branch
from
0189a0f to
4b28dee
Compare
adammathys
reviewed
Oct 26, 2016
| phone: transaction.phone | ||
| transaction.address && transaction.address.to_spree_address.tap do |address| | ||
| address.phone = transaction.phone | ||
| address |
There was a problem hiding this comment.
Don't need to return the object in a tap.
Useful in a few places to translate transaction addresses
cbrunsdon
force-pushed
the
address_improvements
branch
from
4b28dee to
ad4bf67
Compare
adammathys
approved these changes
Oct 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pushes more responsibility onto the TransactionAddress, making it responsible for translating itself into its equivalent Spree address representations.