This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Fix rubocop warnings #313
Merged
Fix rubocop warnings #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use this mixin in this gem, and using the class methods on `FactoryBot` is IMO clearer.
Since Rail 5.0, `belongs_to` associations are required by default, and the preferred syntax for configuring this is using the `optional` configuration key. Since this gem must be compatible with all versions of Solidus down to 2.0, and we used to have belongs_to_required_by_default set to 'false', we do need to specify this default setting. This fixes a Rubocop warning about the redundant validation on the `store` association.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent updates of
rubocop-rspecandrubocop-rails, we got a few new warnings that this PR addresses - some through following the cop's recommendations, some through disabling them.