This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Set sandbox mode if environment is sandbox #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if environment is passed in the options, it is set to a prototype field and then promptly ignored and never used. This configures the paypal client instance to use sandbox mode (through loading with client-id=sb [as per the docs][1]) if the caller has specified the environment to be "sandbox." [1]: https://developer.paypal.com/docs/checkout/reference/customize-sdk/#client-id
swively
approved these changes
May 21, 2021
kennyadsl
reviewed
Jul 2, 2021
| @@ -41,6 +41,7 @@ SolidusPaypalBraintree.PaypalButton.prototype.initializeCallback = function() { | |||
| this._paymentMethodId = this._client.paymentMethodId; | |||
|
|
|||
| this._client.getPaypalInstance().loadPayPalSDK({ | |||
| "client-id": this._environment === "sandbox" ? "sb" : null, | |||
There was a problem hiding this comment.
What about configuring this at _paypalOptions level instead? I see that a lot of other configurations are done this way.
There was a problem hiding this comment.
this._environment does come from the paypalOptions, it just was never being used here.
There was a problem hiding this comment.
Oh, I see. I missed the definition at line 18:
this._environment = this._paypalOptions.environment || 'sandbox';
kennyadsl
approved these changes
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if environment is passed in the options, it is set to a
prototype field and then promptly ignored and never used. This
configures the paypal client instance to use sandbox mode (through
loading with
client-id=sbas per the docs) if the caller hasspecified the environment to be "sandbox."